Page MenuHomePhabricator

Give Duo MFA a stronger hint if users continue without answering the challenge
ClosedPublic

Authored by epriestley on Feb 5 2019, 2:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 1:53 PM
Unknown Object (File)
Dec 26 2023, 8:35 AM
Unknown Object (File)
Nov 13 2023, 7:33 PM
Unknown Object (File)
Nov 13 2023, 7:13 PM
Unknown Object (File)
Oct 26 2023, 9:52 PM
Unknown Object (File)
Sep 16 2023, 8:14 PM
Unknown Object (File)
Sep 14 2023, 11:54 PM
Unknown Object (File)
Sep 12 2023, 3:23 PM
Subscribers
None

Details

Summary

See PHI912. Also, clean up some leftover copy/pastey code here.

Test Plan

Screen Shot 2019-02-04 at 6.37.46 PM.png (420×881 px, 45 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/auth/factor/PhabricatorDuoAuthFactor.php
678–712

This stuff came from SMS/TOTP but isn't relevant for Duo. We have to return an empty result to make some other code work, although perhaps some future followup could simplify this a bit further.

This revision is now accepted and ready to land.Feb 5 2019, 8:08 PM
This revision was automatically updated to reflect the committed changes.