Page MenuHomePhabricator

Use the customizable "Welcome Mail" message in welcome mail
ClosedPublic

Authored by epriestley on Jan 18 2019, 3:08 AM.
Tags
None
Referenced Files
F15508105: D19995.id47729.diff
Wed, Apr 16, 1:42 AM
F15502449: D19995.id47735.diff
Mon, Apr 14, 12:58 AM
F15497977: D19995.id47753.diff
Sun, Apr 13, 11:39 AM
F15492619: D19995.id.diff
Sat, Apr 12, 4:32 PM
F15489677: D19995.diff
Fri, Apr 11, 11:21 AM
F15470364: D19995.id47729.diff
Fri, Apr 4, 9:41 PM
F15453330: D19995.diff
Sat, Mar 29, 10:57 AM
F15446831: D19995.id47729.diff
Thu, Mar 27, 8:27 PM
Subscribers

Details

Summary

Depends on D19994. See PHI1027. If an install has customized the "Welcome Mail" message, include it in welcome mail. A special custom message from the profile screen overrides it, if provided.

(I fiddled with putting the custom message as "placeholder" text in the remarkup area as a hint, but newlines in "placeholder" text appear to have issues in Safari and Firefox. I think this is probably reasonably clear as-is.)

Make both render remarkup-into-text so things like links work properly, as it's reasonably likely that installs will want to link to things.

Test Plan
  • With custom "Welcome Mail" text, sent mail with no custom override (got custom text) and a custom override (got overridden text).
  • Linked to some stuff, got sensible links in the mail (bin/mail show-outbound).

Diff Detail

Repository
rP Phabricator
Branch
welcome6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21587
Build 29427: Run Core Tests
Build 29426: arc lint + arc unit

Event Timeline

  • When the mail body has a global default, make the reminder text link to it.
This revision is now accepted and ready to land.Jan 19 2019, 12:51 AM
This revision was automatically updated to reflect the committed changes.
avivey added inline comments.
src/applications/people/controller/PhabricatorPeopleWelcomeController.php
51

$default_message may return null under some case - maybe any fresh install/upgrade? Is there a default-default value?

src/applications/people/controller/PhabricatorPeopleWelcomeController.php
51

Fixed by D20001.