Page MenuHomePhabricator

Implement Pholio file add/remove transactions without "applyInitialEffects"
ClosedPublic

Authored by epriestley on Dec 20 2018, 9:53 PM.

Details

Summary

Depends on D19924. Ref T11351. Like in D19924, apply these transactions by accepting PHIDs instead of objects so we don't need to juggle the Image objects down to PHIDs in applyInitialEffects.

(Validation is a little light here for now, but only first-party code can reach this, and you can't violate policies or do anything truly bad even if you could pick values to feed in here.)

Test Plan

Created and edited Mocks; added, removed, and reordered images in a Pholio Mock.

Diff Detail

Repository
rP Phabricator
Branch
pholio13
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 21404
Build 29152: Run Core Tests
Build 29151: arc lint + arc unit