Paths

Table of Contentst

Differential D19919

Remove obsolete, no-op implementations of "willRenderTimeline()"
ClosedPublic
Actions

Authored by epriestley on Dec 20 2018, 6:24 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T11351: Move Pholio to EditEngine and modern APIs

Commits

rP937e88c399ab: Remove obsolete, no-op implementations of "willRenderTimeline()"

Summary

Depends on D19918. Ref T11351. In D19918, I removed all calls to this method. Now, remove all implementations.

All of these implementations just return $timeline, only the three sites in D19918 did anything interesting.

Test Plan

Used grep willRenderTimeline to find callsites, found none.

Diff Detail

Repository

rP Phabricator

Branch

pholio7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21396
Build 29137: Run Core Tests
Build 29136: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 20 2018, 6:24 PM

Owners added a subscriber: Restricted Owners Package.Dec 20 2018, 6:24 PM

Harbormaster completed remote builds in B21396: Diff 47543.Dec 20 2018, 6:26 PM

epriestley requested review of this revision.Dec 20 2018, 6:26 PM

epriestley added a child revision: D19920: Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface.Dec 20 2018, 6:43 PM

https://en.wikipedia.org/wiki/Semantic_satiation

This revision is now accepted and ready to land.Dec 20 2018, 8:29 PM

Closed by commit rP937e88c399ab: Remove obsolete, no-op implementations of "willRenderTimeline()" (authored by epriestley). · Explain WhyDec 20 2018, 11:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

storage/

6 lines

7 lines

6 lines

6 lines

7 lines

7 lines

auth/

storage/

PhabricatorAuthPassword.php

8 lines

PhabricatorAuthProviderConfig.php

7 lines

PhabricatorAuthSSHKey.php

6 lines

badges/

storage/

PhabricatorBadgesBadge.php

7 lines

base/

PhabricatorApplication.php

6 lines

calendar/

storage/

PhabricatorCalendarEvent.php

6 lines

PhabricatorCalendarExport.php

7 lines

PhabricatorCalendarImport.php

6 lines

config/

storage/

PhabricatorConfigEntry.php

7 lines

conpherence/

storage/

ConpherenceThread.php

5 lines

countdown/

storage/

PhabricatorCountdown.php

6 lines

dashboard/

storage/

PhabricatorDashboard.php

7 lines

PhabricatorDashboardPanel.php

7 lines

differential/

storage/

DifferentialDiff.php

7 lines

diviner/

storage/

DivinerLiveBook.php

7 lines

drydock/

storage/

DrydockBlueprint.php

7 lines

files/

storage/

PhabricatorFile.php

7 lines

fund/

storage/

FundBacker.php

7 lines

FundInitiative.php

7 lines

harbormaster/

storage/

HarbormasterBuildable.php

7 lines

build/

HarbormasterBuild.php

7 lines

configuration/

HarbormasterBuildPlan.php

8 lines

HarbormasterBuildStep.php

7 lines

herald/

storage/

HeraldRule.php

7 lines

HeraldWebhook.php

6 lines

legalpad/

storage/

LegalpadDocument.php

7 lines

macro/

storage/

PhabricatorFileImageMacro.php

7 lines

maniphest/

storage/

ManiphestTask.php

7 lines

metamta/

storage/

PhabricatorMetaMTAApplicationEmail.php

6 lines

nuance/

storage/

NuanceItem.php

6 lines

NuanceQueue.php

6 lines

NuanceSource.php

7 lines

oauthserver/

storage/

PhabricatorOAuthServerClient.php

6 lines

owners/

storage/

PhabricatorOwnersPackage.php

6 lines

packages/

storage/

PhabricatorPackagesPackage.php

6 lines

PhabricatorPackagesPublisher.php

6 lines

PhabricatorPackagesVersion.php

6 lines

passphrase/

storage/

PassphraseCredential.php

7 lines

paste/

storage/

PhabricatorPaste.php

7 lines

people/

storage/

PhabricatorUser.php

6 lines

phame/

storage/

PhameBlog.php

6 lines

PhamePost.php

7 lines

phlux/

storage/

PhluxVariable.php

7 lines

phortune/

storage/

PhortuneAccount.php

7 lines

PhortuneCart.php

7 lines

PhortuneMerchant.php

7 lines

PhortunePaymentProviderConfig.php

7 lines

phriction/

storage/

PhrictionDocument.php

7 lines

phurl/

storage/

PhabricatorPhurlURL.php

6 lines

ponder/

storage/

PonderAnswer.php

7 lines

PonderQuestion.php

7 lines

project/

storage/

PhabricatorProject.php

7 lines

PhabricatorProjectColumn.php

7 lines

releeph/

storage/

ReleephBranch.php

7 lines

ReleephProject.php

7 lines

ReleephRequest.php

7 lines

repository/

storage/

PhabricatorRepository.php

7 lines

PhabricatorRepositoryIdentity.php

7 lines

PhabricatorRepositoryURI.php

6 lines

search/

storage/

PhabricatorProfileMenuItemConfiguration.php

7 lines

settings/

storage/

PhabricatorUserPreferences.php

6 lines

slowvote/

storage/

PhabricatorSlowvotePoll.php

7 lines

spaces/

storage/

PhabricatorSpacesNamespace.php

6 lines

transactions/

storage/

PhabricatorEditEngineConfiguration.php

6 lines

infrastructure/

daemon/

workers/

storage/

PhabricatorWorkerBulkJob.php

5 lines

Diff 47543

View Options

src/applications/almanac/storage/AlmanacBinding.php

View Options

src/applications/almanac/storage/AlmanacDevice.php

View Options

src/applications/almanac/storage/AlmanacInterface.php

View Options

src/applications/almanac/storage/AlmanacNamespace.php

View Options

src/applications/almanac/storage/AlmanacNetwork.php

View Options

src/applications/almanac/storage/AlmanacService.php

View Options

src/applications/auth/storage/PhabricatorAuthPassword.php

View Options

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

View Options

src/applications/auth/storage/PhabricatorAuthSSHKey.php

View Options

src/applications/badges/storage/PhabricatorBadgesBadge.php

View Options

src/applications/base/PhabricatorApplication.php

View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

View Options

src/applications/calendar/storage/PhabricatorCalendarExport.php

View Options

src/applications/calendar/storage/PhabricatorCalendarImport.php

View Options

src/applications/config/storage/PhabricatorConfigEntry.php

View Options

src/applications/conpherence/storage/ConpherenceThread.php

View Options

src/applications/countdown/storage/PhabricatorCountdown.php

View Options

src/applications/dashboard/storage/PhabricatorDashboard.php

View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

View Options

src/applications/differential/storage/DifferentialDiff.php

View Options

src/applications/diviner/storage/DivinerLiveBook.php

View Options

src/applications/drydock/storage/DrydockBlueprint.php

View Options

src/applications/files/storage/PhabricatorFile.php

View Options

src/applications/fund/storage/FundBacker.php

View Options

src/applications/fund/storage/FundInitiative.php

View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php

View Options

src/applications/herald/storage/HeraldRule.php

View Options

src/applications/herald/storage/HeraldWebhook.php

View Options

src/applications/legalpad/storage/LegalpadDocument.php

View Options

src/applications/macro/storage/PhabricatorFileImageMacro.php

View Options

src/applications/maniphest/storage/ManiphestTask.php

View Options

src/applications/metamta/storage/PhabricatorMetaMTAApplicationEmail.php

View Options

src/applications/nuance/storage/NuanceItem.php

View Options

src/applications/nuance/storage/NuanceQueue.php

View Options

src/applications/nuance/storage/NuanceSource.php

View Options

src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php

View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

View Options

src/applications/packages/storage/PhabricatorPackagesPackage.php

View Options

src/applications/packages/storage/PhabricatorPackagesPublisher.php

View Options

src/applications/packages/storage/PhabricatorPackagesVersion.php

View Options

src/applications/passphrase/storage/PassphraseCredential.php

View Options

src/applications/paste/storage/PhabricatorPaste.php

View Options

src/applications/people/storage/PhabricatorUser.php

View Options

src/applications/phame/storage/PhameBlog.php

View Options

src/applications/phame/storage/PhamePost.php

View Options

src/applications/phlux/storage/PhluxVariable.php

View Options

src/applications/phortune/storage/PhortuneAccount.php

View Options

src/applications/phortune/storage/PhortuneCart.php

View Options

src/applications/phortune/storage/PhortuneMerchant.php

View Options

src/applications/phortune/storage/PhortunePaymentProviderConfig.php

View Options

src/applications/phriction/storage/PhrictionDocument.php

View Options

src/applications/phurl/storage/PhabricatorPhurlURL.php

View Options

src/applications/ponder/storage/PonderAnswer.php

View Options

src/applications/ponder/storage/PonderQuestion.php

View Options

src/applications/project/storage/PhabricatorProject.php

View Options

src/applications/project/storage/PhabricatorProjectColumn.php

View Options

src/applications/releeph/storage/ReleephBranch.php

View Options

src/applications/releeph/storage/ReleephProject.php

View Options

src/applications/releeph/storage/ReleephRequest.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/repository/storage/PhabricatorRepositoryIdentity.php

View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

View Options

src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php

View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

View Options

src/applications/spaces/storage/PhabricatorSpacesNamespace.php

View Options

src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php

View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php

Remove obsolete, no-op implementations of "willRenderTimeline()"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47543

src/applications/almanac/storage/AlmanacBinding.php

src/applications/almanac/storage/AlmanacDevice.php

src/applications/almanac/storage/AlmanacInterface.php

src/applications/almanac/storage/AlmanacNamespace.php

src/applications/almanac/storage/AlmanacNetwork.php

src/applications/almanac/storage/AlmanacService.php

src/applications/auth/storage/PhabricatorAuthPassword.php

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

src/applications/auth/storage/PhabricatorAuthSSHKey.php

src/applications/badges/storage/PhabricatorBadgesBadge.php

src/applications/base/PhabricatorApplication.php

src/applications/calendar/storage/PhabricatorCalendarEvent.php

src/applications/calendar/storage/PhabricatorCalendarExport.php

src/applications/calendar/storage/PhabricatorCalendarImport.php

src/applications/config/storage/PhabricatorConfigEntry.php

src/applications/conpherence/storage/ConpherenceThread.php

src/applications/countdown/storage/PhabricatorCountdown.php

src/applications/dashboard/storage/PhabricatorDashboard.php

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

src/applications/differential/storage/DifferentialDiff.php

src/applications/diviner/storage/DivinerLiveBook.php

src/applications/drydock/storage/DrydockBlueprint.php

src/applications/files/storage/PhabricatorFile.php

src/applications/fund/storage/FundBacker.php

src/applications/fund/storage/FundInitiative.php

src/applications/harbormaster/storage/HarbormasterBuildable.php

src/applications/harbormaster/storage/build/HarbormasterBuild.php

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php

src/applications/herald/storage/HeraldRule.php

src/applications/herald/storage/HeraldWebhook.php

src/applications/legalpad/storage/LegalpadDocument.php

src/applications/macro/storage/PhabricatorFileImageMacro.php

src/applications/maniphest/storage/ManiphestTask.php

src/applications/metamta/storage/PhabricatorMetaMTAApplicationEmail.php

src/applications/nuance/storage/NuanceItem.php

src/applications/nuance/storage/NuanceQueue.php

src/applications/nuance/storage/NuanceSource.php

src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php

src/applications/owners/storage/PhabricatorOwnersPackage.php

src/applications/packages/storage/PhabricatorPackagesPackage.php

src/applications/packages/storage/PhabricatorPackagesPublisher.php

src/applications/packages/storage/PhabricatorPackagesVersion.php

src/applications/passphrase/storage/PassphraseCredential.php

src/applications/paste/storage/PhabricatorPaste.php

src/applications/people/storage/PhabricatorUser.php

src/applications/phame/storage/PhameBlog.php

src/applications/phame/storage/PhamePost.php

src/applications/phlux/storage/PhluxVariable.php

src/applications/phortune/storage/PhortuneAccount.php

src/applications/phortune/storage/PhortuneCart.php

src/applications/phortune/storage/PhortuneMerchant.php

src/applications/phortune/storage/PhortunePaymentProviderConfig.php

src/applications/phriction/storage/PhrictionDocument.php

src/applications/phurl/storage/PhabricatorPhurlURL.php

src/applications/ponder/storage/PonderAnswer.php

src/applications/ponder/storage/PonderQuestion.php

src/applications/project/storage/PhabricatorProject.php

src/applications/project/storage/PhabricatorProjectColumn.php

src/applications/releeph/storage/ReleephBranch.php

src/applications/releeph/storage/ReleephProject.php

src/applications/releeph/storage/ReleephRequest.php

src/applications/repository/storage/PhabricatorRepository.php

src/applications/repository/storage/PhabricatorRepositoryIdentity.php

src/applications/repository/storage/PhabricatorRepositoryURI.php

src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php

src/applications/settings/storage/PhabricatorUserPreferences.php

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

src/applications/spaces/storage/PhabricatorSpacesNamespace.php

src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php

src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php

Remove obsolete, no-op implementations of "willRenderTimeline()"
ClosedPublic
Actions

Revision Contents
Changeset List