Page MenuHomePhabricator

Make Images in Pholio refer to mocks by PHID instead of ID
ClosedPublic

Authored by epriestley on Dec 19 2018, 7:21 PM.

Details

Summary

Ref T11351. In Pholio, we currently use a mockID, but a mockPHID is generally preferable / more modern / more flexible. In particular, we need PHIDs to load handles and prefer PHIDs when exposing information to the API, and using PHIDs internally makes a bunch of things easier/better/faster and ~nothing harder/worse/slower.

I'll add some inlines about a few things.

Test Plan

Ran migrations, spot-checked database for sanity. Loaded Pholio, saw data unchanged. Created and edited images.

Diff Detail

Repository
rP Phabricator
Branch
pholio5
Lint
Lint OK
SeverityLocationCodeMessage
Advicesrc/applications/pholio/storage/PholioImage.php:40XHP16TODO Comment
Unit
Unit Tests OK
Build Status
Buildable 21388
Build 29123: Run Core Tests
Build 29122: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 19 2018, 7:21 PM
Owners added a subscriber: Restricted Owners Package.Dec 19 2018, 7:21 PM
epriestley requested review of this revision.Dec 19 2018, 7:22 PM
epriestley added inline comments.Dec 19 2018, 7:24 PM
src/applications/pholio/query/PholioImageQuery.php
29–32

This has no callers, so I removed it for now. Previously, I believe Pholio only showed current versions of images, so this probably dates to that earlier time.

src/applications/pholio/storage/PholioImage.php
40–47

For now, I've just removed these keys:

  • We'll get an automatic key_phid on bin/storage upgrade by default now that we're no longer suppressing it with null.
  • We should have some kind of key_mock, but since isObsolete is never queried for it probably shouldn't be <mock, isObsolete, ...>. I'll add this key back once I figure out what it should be.
amckinley accepted this revision.Dec 19 2018, 9:49 PM
This revision is now accepted and ready to land.Dec 19 2018, 9:49 PM
This revision was automatically updated to reflect the committed changes.