Page MenuHomePhabricator

Continue cleaning up queries in the wake of changes to "%Q"
ClosedPublic

Authored by epriestley on Nov 15 2018, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 3:55 PM
Unknown Object (File)
Fri, Apr 19, 8:07 PM
Unknown Object (File)
Thu, Apr 11, 9:36 AM
Unknown Object (File)
Sat, Mar 30, 4:33 PM
Unknown Object (File)
Fri, Mar 29, 11:25 AM
Unknown Object (File)
Thu, Mar 28, 11:57 PM
Unknown Object (File)
Mar 19 2024, 10:40 PM
Unknown Object (File)
Mar 18 2024, 1:44 PM
Subscribers

Details

Summary

Depends on D19810. Ref T13217. Ref T13216. I mostly used grep implode | grep OR and grep implode | grep AND to find these -- not totally exhaustive but should be a big chunk of the callsites that are missing %LO / %LA.

Test Plan

These are tricky to test exhaustively, but I made an attempt to hit most of them:

  • Browsed Almanac interfaces.
  • Created/browsed Calendar events.
  • Enabled/disabled/showed the lock log.
  • Browsed repositories.
  • Loaded Facts UI.
  • Poked at Multimeter.
  • Used typeahead for users and projects.
  • Browsed Phriction.
  • Ran various fulltext searches.

Not sure these are reachable:

  • All the lint stuff might be dead/unreachable/nonfunctional?

Diff Detail

Repository
rP Phabricator
Branch
query7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21165
Build 28780: Run Core Tests
Build 28779: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
1749

We clearly need an`%L+` operator for this extremely common pattern.

This revision is now accepted and ready to land.Nov 16 2018, 7:36 PM

Haha, yeah. Differential had one UNION ALL too but %LU seemed a little ridiculous.

MySQL has a SUM() function but it only works on aggregates and I couldn't find any way to express this as ADD_THESE_UP(%LQ).

This revision was automatically updated to reflect the committed changes.