Page MenuHomePhabricator
Differential D19814

Continue cleaning up queries in the wake of changes to "%Q"
ClosedPublic
Actions

Authored by epriestley on Nov 15 2018, 2:00 PM.
Tags
None
Referenced Files
F15452748: D19814.diff
Sat, Mar 29, 7:04 AM
F15448937: D19814.id47316.diff
Fri, Mar 28, 7:47 AM
F15445493: D19814.id.diff
Thu, Mar 27, 2:12 PM
F15444611: D19814.diff
Thu, Mar 27, 10:21 AM
F15441946: D19814.diff
Wed, Mar 26, 8:42 PM
F15433395: D19814.id47329.diff
Mon, Mar 24, 10:59 PM
F15392895: D19814.diff
Sat, Mar 15, 6:18 PM
F15381741: D19814.diff
Fri, Mar 14, 9:11 AM
View All Files
Subscribers
yelirekim

Details

Reviewers
amckinley
Maniphest Tasks
T13216: 2018 Week 45-47 Bonus Content
T13217: Upgrading: Hardening of qsprintf()
Commits
rP933462b4873b: Continue cleaning up queries in the wake of changes to "%Q"
Summary

Depends on D19810. Ref T13217. Ref T13216. I mostly used grep implode | grep OR and grep implode | grep AND to find these -- not totally exhaustive but should be a big chunk of the callsites that are missing %LO / %LA.

Test Plan

These are tricky to test exhaustively, but I made an attempt to hit most of them:

  • Browsed Almanac interfaces.
  • Created/browsed Calendar events.
  • Enabled/disabled/showed the lock log.
  • Browsed repositories.
  • Loaded Facts UI.
  • Poked at Multimeter.
  • Used typeahead for users and projects.
  • Browsed Phriction.
  • Ran various fulltext searches.

Not sure these are reachable:

  • All the lint stuff might be dead/unreachable/nonfunctional?

Diff Detail

Repository
rP Phabricator
Branch
query7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21165
Build 28780: Run Core Tests
Build 28779: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 15 2018, 2:00 PM
Herald added a subscriber: yelirekim. · View Herald TranscriptNov 15 2018, 2:00 PM
Harbormaster completed remote builds in B21165: Diff 47316.Nov 15 2018, 2:02 PM
epriestley requested review of this revision.Nov 15 2018, 2:02 PM
epriestley added a child revision: D19816: Unify intracluster sync and Drydock working copy construction timeouts as a repository "copy time limit".Nov 16 2018, 5:19 PM
amckinley accepted this revision.Nov 16 2018, 7:36 PM
amckinley added inline comments.
src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
1749

We clearly need an`%L+` operator for this extremely common pattern.

This revision is now accepted and ready to land.Nov 16 2018, 7:36 PM
epriestley added a comment.Nov 16 2018, 8:41 PM

Haha, yeah. Differential had one UNION ALL too but %LU seemed a little ridiculous.

MySQL has a SUM() function but it only works on aggregates and I couldn't find any way to express this as ADD_THESE_UP(%LQ).

Closed by commit rP933462b4873b: Continue cleaning up queries in the wake of changes to "%Q" (authored by epriestley). · Explain WhyNov 16 2018, 8:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
query/
2 lines
calendar/
query/
4 lines
daemon/
management/
4 lines
diffusion/
8 lines
conduit/
4 lines
controller/
12 lines
query/
4 lines
fact/
query/
4 lines
multimeter/
controller/
8 lines
packages/
query/
2 lines
people/
query/
2 lines
phrequent/
query/
4 lines
phriction/
query/
8 lines
project/
query/
2 lines
infrastructure/
query/
policy/
35 lines

Diff 47316

View Options

src/applications/almanac/query/AlmanacInterfaceQuery.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Loading...
View Options

src/applications/daemon/management/PhabricatorLockLogManagementWorkflow.php

Loading...
View Options

src/applications/diffusion/DiffusionLintSaveRunner.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionLintController.php

Loading...
View Options

src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php

Loading...
View Options

src/applications/fact/query/PhabricatorFactDatapointQuery.php

Loading...
View Options

src/applications/multimeter/controller/MultimeterSampleController.php

Loading...
View Options

src/applications/packages/query/PhabricatorPackagesQuery.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...
View Options

src/applications/phrequent/query/PhrequentUserTimeQuery.php

Loading...
View Options

src/applications/phriction/query/PhrictionDocumentQuery.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectQuery.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility