Page MenuHomePhabricator

Continue cleaning up queries in the wake of changes to "%Q"
ClosedPublic

Authored by epriestley on Nov 15 2018, 2:00 PM.
Tags
None
Referenced Files
F19508167: D19814.id47316.diff
Sat, Jan 10, 1:49 AM
F19090584: D19814.id.diff
Dec 3 2025, 12:21 PM
F19086179: D19814.diff
Dec 2 2025, 8:46 PM
F19082866: D19814.id47329.diff
Dec 2 2025, 12:26 PM
F18990258: D19814.diff
Nov 18 2025, 5:33 PM
F18984973: D19814.id47316.diff
Nov 17 2025, 12:49 PM
F18862212: D19814.diff
Nov 2 2025, 6:21 PM
F18759453: D19814.id47329.diff
Oct 6 2025, 3:53 AM
Subscribers

Details

Summary

Depends on D19810. Ref T13217. Ref T13216. I mostly used grep implode | grep OR and grep implode | grep AND to find these -- not totally exhaustive but should be a big chunk of the callsites that are missing %LO / %LA.

Test Plan

These are tricky to test exhaustively, but I made an attempt to hit most of them:

  • Browsed Almanac interfaces.
  • Created/browsed Calendar events.
  • Enabled/disabled/showed the lock log.
  • Browsed repositories.
  • Loaded Facts UI.
  • Poked at Multimeter.
  • Used typeahead for users and projects.
  • Browsed Phriction.
  • Ran various fulltext searches.

Not sure these are reachable:

  • All the lint stuff might be dead/unreachable/nonfunctional?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
1749

We clearly need an`%L+` operator for this extremely common pattern.

This revision is now accepted and ready to land.Nov 16 2018, 7:36 PM

Haha, yeah. Differential had one UNION ALL too but %LU seemed a little ridiculous.

MySQL has a SUM() function but it only works on aggregates and I couldn't find any way to express this as ADD_THESE_UP(%LQ).

This revision was automatically updated to reflect the committed changes.