Page MenuHomePhabricator

When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision"

Authored by epriestley on Nov 15 2018, 1:14 PM.



See PHI975. Ref T13216. Ref T2543. Previously, see D19204 and PHI433.

When you're acting on a draft revision, we change the button text to "Submit Quietly" as a hint that your actions don't generate notifications yet.

However, this isn't accurate when one of your actions is "Request Review", which causes the revision to publish.

Allow actions to override the submit button text, and make the "Request Review" action change the button text to "Publish Revision".

The alternative change I considered was to remove the word "Quietly" in all cases.

I'm not thrilled about how complex this change is to adjust one word, but the various pieces are all fairly clean individually. I'm not sure we'll ever be able to use it for anything else, but I do suspect that the word "Quietly" was the change in D19204 with the largest effect by far (see T10000).

Test Plan
  • Created a draft revision. Saw "Submit Quietly" text.
  • Added a "Request Review" action, saw it change to "Publish Revision".
  • Reloaded page, saw stack saved and "Publish Revision".
  • Removed action, saw "Submit Quietly".
  • Repeated on a non-draft revision, button stayed put as "Submit".
  • Submitted the various actions, saw them have the desired effects.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 15 2018, 1:14 PM
epriestley edited the summary of this revision. (Show Details)Nov 15 2018, 1:15 PM
epriestley requested review of this revision.Nov 15 2018, 1:15 PM
epriestley marked an inline comment as done.Nov 15 2018, 1:16 PM
epriestley added inline comments.

Unrelated qsprintf() fix, repro is to load revisions with some (particular?) packages configured.

amckinley accepted this revision.Nov 16 2018, 12:07 AM
This revision is now accepted and ready to land.Nov 16 2018, 12:07 AM
This revision was automatically updated to reflect the committed changes.