Page MenuHomePhabricator

Remove nonfunctional AJAX embed behavior for Slowvote
ClosedPublic

Authored by epriestley on Nov 5 2018, 6:12 PM.
Tags
None
Referenced Files
F13052219: D19773.id47239.diff
Fri, Apr 19, 7:50 AM
Unknown Object (File)
Tue, Apr 16, 11:09 PM
Unknown Object (File)
Tue, Apr 16, 10:25 PM
Unknown Object (File)
Sat, Apr 13, 8:30 PM
Unknown Object (File)
Sat, Apr 13, 8:09 PM
Unknown Object (File)
Thu, Apr 11, 8:14 AM
Unknown Object (File)
Fri, Apr 5, 6:22 PM
Unknown Object (File)
Fri, Mar 29, 3:20 PM
Subscribers
None

Details

Summary

See https://hackerone.com/reports/434116. Slowvote has a piece of Javascript that attempts to let you vote on {V123} polls inline.

It does not work: nothing ever triggers it (nothing renders a control with a slowvote-option sigil).

At least for now, just remove it. It has a completely separate pathway in the controller and both pathways are buggy, so this makes fixing them easier.

Test Plan

Voted in plurality and approval polls via Slowvote and the embedded widget.

Diff Detail

Repository
rP Phabricator
Branch
xvote1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21081
Build 28647: Run Core Tests
Build 28646: arc lint + arc unit