Page MenuHomePhabricator

Remove nonfunctional AJAX embed behavior for Slowvote
ClosedPublic

Authored by epriestley on Nov 5 2018, 6:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 2, 12:08 AM
Unknown Object (File)
Thu, Jan 30, 7:48 PM
Unknown Object (File)
Thu, Jan 30, 7:48 PM
Unknown Object (File)
Thu, Jan 30, 7:48 PM
Unknown Object (File)
Tue, Jan 28, 8:26 PM
Unknown Object (File)
Sat, Jan 25, 10:38 AM
Unknown Object (File)
Fri, Jan 24, 12:53 PM
Unknown Object (File)
Wed, Jan 22, 3:47 AM
Subscribers
None

Details

Summary

See https://hackerone.com/reports/434116. Slowvote has a piece of Javascript that attempts to let you vote on {V123} polls inline.

It does not work: nothing ever triggers it (nothing renders a control with a slowvote-option sigil).

At least for now, just remove it. It has a completely separate pathway in the controller and both pathways are buggy, so this makes fixing them easier.

Test Plan

Voted in plurality and approval polls via Slowvote and the embedded widget.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable