Page MenuHomePhabricator

Remove nonfunctional AJAX embed behavior for Slowvote
ClosedPublic

Authored by epriestley on Nov 5 2018, 6:12 PM.

Details

Summary

See https://hackerone.com/reports/434116. Slowvote has a piece of Javascript that attempts to let you vote on {V123} polls inline.

It does not work: nothing ever triggers it (nothing renders a control with a slowvote-option sigil).

At least for now, just remove it. It has a completely separate pathway in the controller and both pathways are buggy, so this makes fixing them easier.

Test Plan

Voted in plurality and approval polls via Slowvote and the embedded widget.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 5 2018, 6:12 PM
epriestley requested review of this revision.Nov 5 2018, 6:13 PM
amckinley accepted this revision.Nov 6 2018, 4:20 PM
This revision is now accepted and ready to land.Nov 6 2018, 4:20 PM
This revision was automatically updated to reflect the committed changes.