Page MenuHomePhabricator

Remove nonfunctional AJAX embed behavior for Slowvote
ClosedPublic

Authored by epriestley on Nov 5 2018, 6:12 PM.
Tags
None
Referenced Files
F19867961: D19773.diff
Sun, Mar 15, 1:20 AM
F19815968: D19773.diff
Thu, Mar 5, 2:15 AM
F19812553: D19773.diff
Wed, Mar 4, 5:26 AM
F19802208: D19773.diff
Sun, Mar 1, 2:27 PM
F19598319: D19773.diff
Feb 2 2026, 10:49 PM
F19542012: D19773.diff
Jan 22 2026, 7:07 AM
F19524467: D19773.diff
Jan 18 2026, 1:15 AM
F19260896: D19773.diff
Dec 22 2025, 4:30 PM
Subscribers
None

Details

Summary

See https://hackerone.com/reports/434116. Slowvote has a piece of Javascript that attempts to let you vote on {V123} polls inline.

It does not work: nothing ever triggers it (nothing renders a control with a slowvote-option sigil).

At least for now, just remove it. It has a completely separate pathway in the controller and both pathways are buggy, so this makes fixing them easier.

Test Plan

Voted in plurality and approval polls via Slowvote and the embedded widget.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable