HomePhabricator

Correct an ambiguous regexp in DiffusionRequest

Description

Correct an ambiguous regexp in DiffusionRequest

Summary:
See https://discourse.phabricator-community.org/t/diffusionrequest-regex-error/2057/.

The intent of [\d-,] is "digits, hyphen, and comma" but [x-y] means "character range x-y".

Specify [\d,-] instead to disambiguate the hyphen as "literal hyphen", not a character range marker.

Test Plan: I can't reproduce the original error as reported, but browsed around Diffusion for a bit.

Reviewers: amckinley, avivey

Reviewed By: avivey

Differential Revision: https://secure.phabricator.com/D19770

Details

Provenance
epriestleyAuthored on Nov 2 2018, 2:55 AM
epriestleyPushed on Nov 2 2018, 3:01 AM
Reviewer
avivey
Differential Revision
D19770: Correct an ambiguous regexp in DiffusionRequest
Parents
rP9bea00c159b6: Add harbormaster.buildplan.search api method
Branches
Unknown
Tags
Unknown
Build Status
Buildable 21076
Build 28639: Run Core Tests