Page MenuHomePhabricator

Prevent users from voting for invalid Slowvote options
ClosedPublic

Authored by epriestley on Nov 5 2018, 6:23 PM.
Tags
None
Referenced Files
F15464819: D19774.id47233.diff
Wed, Apr 2, 12:51 PM
F15454547: D19774.diff
Sat, Mar 29, 7:02 PM
F15429229: D19774.id47233.diff
Mon, Mar 24, 1:14 AM
F15399520: D19774.id47240.diff
Mon, Mar 17, 4:59 AM
F15395670: D19774.id.diff
Sun, Mar 16, 8:51 AM
F15377266: D19774.id47233.diff
Thu, Mar 13, 8:30 AM
F15338206: D19774.id47240.diff
Sun, Mar 9, 9:52 AM
Unknown Object (File)
Feb 22 2025, 7:36 PM
Subscribers
None

Details

Summary

Depends on D19773. See https://hackerone.com/reports/434116. You can currently vote for invalid options by submitting, e.g., vote[]=12345.

By doing this, you can see the responses, which is sort of theoretically a security problem? This is definitely a bug, regardless.

Instead, only allow users to vote for options which are actually part of the poll.

Test Plan
  • Tried to vote for invalid options by editing the form to vote[]=12345 (got error).
  • Tried to vote for invalid options by editing the radio buttons on a plurality poll into checkboxes, checking multiple boxes, and submitting (got error).
  • Voted in approval and plurality polls the right way, from the main web UI and from the embed ({V...}) UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable