Page MenuHomePhabricator

After a Drydock lease triggers a resource to be reclaimed, stop it from triggering another reclaim until the first one completes
ClosedPublic

Authored by epriestley on Oct 24 2018, 4:15 PM.
Tags
None
Referenced Files
F14178457: D19753.diff
Sun, Dec 8, 10:30 PM
Unknown Object (File)
Sun, Dec 1, 4:49 PM
Unknown Object (File)
Wed, Nov 20, 3:38 PM
Unknown Object (File)
Sat, Nov 16, 10:34 PM
Unknown Object (File)
Sat, Nov 16, 11:06 AM
Unknown Object (File)
Tue, Nov 12, 1:19 PM
Unknown Object (File)
Mon, Nov 11, 2:10 AM
Unknown Object (File)
Nov 8 2024, 1:04 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19752. Ref T13210. If resources take a long time to reclaim/destroy (normally, more than 15 seconds) a single new lease may update several times during the reclaim/destroy process and end up reclaiming multiple resources.

Instead: after a lease triggers a reclaim, prevent it from triggering another reclaim as long as the resource it is reclaiming hasn't finished its reclaim/destroy cycle. Basically, each lease only gets to destroy one resource at a time.

Test Plan
  • Added a sleep(120) to destroyResource() to simulate a long reclaim/destroy cycle.
  • Allocated A, A, A working copies. Leased a B working copy.
  • Before patch: saw "B" lease destroy all three "A" working copies after ~0, ~15, and ~30 seconds, then build a new "B" resource after ~120 seconds (when the first reclaim/destroy finished).
  • After patch: saw "B" lease destroy one "A" working copy after ~0 seconds, then wait patiently until it finished up, then build a new "B" resource.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable