Page MenuHomePhabricator

In "bin/drydock lease", take a JSON "--attributes" so we can accept complex values
ClosedPublic

Authored by epriestley on Oct 24 2018, 2:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 11:49 AM
Unknown Object (File)
Thu, Mar 21, 9:19 AM
Unknown Object (File)
Sat, Mar 9, 3:38 AM
Unknown Object (File)
Wed, Feb 28, 1:15 PM
Unknown Object (File)
Feb 3 2024, 7:40 PM
Unknown Object (File)
Jan 25 2024, 1:20 AM
Unknown Object (File)
Jan 20 2024, 10:08 AM
Unknown Object (File)
Dec 22 2023, 12:33 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19750. See T13210. The bin/drydock lease command makes it easier to request ad-hoc leases, but currently takes lease attributes in the form --attributes x=y,a=b.

This was okay for all leases at the time, but doesn't really work for modern WorkingCopy resources since they take a repositories.map which has a dictionary as a value. You can't specify that with repositories.map=....

Instead, point --attributes at a JSON file or use --attributes - to read from stdin.

Test Plan

Used --attributes with a file and stdin to allocate working copy leases with repositories.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable