Page MenuHomePhabricator

In "bin/drydock lease", take a JSON "--attributes" so we can accept complex values
ClosedPublic

Authored by epriestley on Oct 24 2018, 2:22 PM.
Tags
None
Referenced Files
F19122298: D19751.diff
Dec 9 2025, 11:21 PM
F19060038: D19751.id47183.diff
Nov 29 2025, 7:43 AM
F19045514: D19751.id47183.diff
Nov 27 2025, 7:56 AM
F18837069: D19751.diff
Oct 27 2025, 4:16 AM
F18815688: D19751.id47201.diff
Oct 21 2025, 3:12 AM
F18815687: D19751.id47183.diff
Oct 21 2025, 3:12 AM
F18815265: D19751.id.diff
Oct 21 2025, 1:31 AM
F18815210: D19751.diff
Oct 21 2025, 1:18 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19750. See T13210. The bin/drydock lease command makes it easier to request ad-hoc leases, but currently takes lease attributes in the form --attributes x=y,a=b.

This was okay for all leases at the time, but doesn't really work for modern WorkingCopy resources since they take a repositories.map which has a dictionary as a value. You can't specify that with repositories.map=....

Instead, point --attributes at a JSON file or use --attributes - to read from stdin.

Test Plan

Used --attributes with a file and stdin to allocate working copy leases with repositories.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable