Page MenuHomePhabricator

In "bin/drydock lease", take a JSON "--attributes" so we can accept complex values
ClosedPublic

Authored by epriestley on Oct 24 2018, 2:22 PM.
Tags
None
Referenced Files
F19818914: D19751.diff
Mar 6 2026, 1:16 AM
F19818912: D19751.diff
Mar 6 2026, 1:15 AM
F19813256: D19751.diff
Mar 4 2026, 8:33 AM
F19700958: D19751.diff
Feb 10 2026, 9:56 PM
F19668774: D19751.id.diff
Feb 7 2026, 7:50 PM
F19647685: D19751.id.diff
Feb 6 2026, 3:58 AM
F19555908: D19751.diff
Jan 30 2026, 7:07 PM
F19532000: D19751.diff
Jan 20 2026, 8:18 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19750. See T13210. The bin/drydock lease command makes it easier to request ad-hoc leases, but currently takes lease attributes in the form --attributes x=y,a=b.

This was okay for all leases at the time, but doesn't really work for modern WorkingCopy resources since they take a repositories.map which has a dictionary as a value. You can't specify that with repositories.map=....

Instead, point --attributes at a JSON file or use --attributes - to read from stdin.

Test Plan

Used --attributes with a file and stdin to allocate working copy leases with repositories.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable