Page MenuHomePhabricator

In "bin/drydock lease", take a JSON "--attributes" so we can accept complex values
ClosedPublic

Authored by epriestley on Oct 24 2018, 2:22 PM.
Tags
None
Referenced Files
F21322079: D19751.diff
Thu, Jul 9, 8:17 PM
Unknown Object (File)
Sat, Jul 4, 12:41 PM
Unknown Object (File)
Fri, Jun 19, 10:33 PM
Unknown Object (File)
Jun 6 2026, 4:19 AM
Unknown Object (File)
Apr 17 2026, 11:46 PM
Unknown Object (File)
Mar 6 2026, 1:16 AM
Unknown Object (File)
Mar 6 2026, 1:15 AM
Unknown Object (File)
Mar 4 2026, 8:33 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19750. See T13210. The bin/drydock lease command makes it easier to request ad-hoc leases, but currently takes lease attributes in the form --attributes x=y,a=b.

This was okay for all leases at the time, but doesn't really work for modern WorkingCopy resources since they take a repositories.map which has a dictionary as a value. You can't specify that with repositories.map=....

Instead, point --attributes at a JSON file or use --attributes - to read from stdin.

Test Plan

Used --attributes with a file and stdin to allocate working copy leases with repositories.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable