Page MenuHomePhabricator

When a Drydock lease schedules a resource to be reclaimed, awaken the lease update task when the reclaim completes
ClosedPublic

Authored by epriestley on Oct 24 2018, 2:59 PM.

Details

Summary

Depends on D19751. Ref T13210. When Drydock needs to reclaim an existing unused resource in order to build a new resource to satisfy a lease, the lease which triggered the reclaim currently gets thrown back into the pool with a 15-second yield.

If the queue is pretty empty and the reclaim is quick, this can mean that we spend up to 15 extra seconds just waiting for the lease update task to get another shot at building a resource (the resource reclaim may complete in a second or two, but nothing else happens until the yield ends).

Instead, when a lease triggers a reclaim, have the reclaim reawaken the lease task when it completes. In the best case, this saves us 15 seconds of waiting. In other cases (the task already completed some other way, the resource gets claimed before the lease gets to it), it's harmless.

Test Plan
  • Allocated A, A, A working copies with limit 3. Leased a B working copy.
  • Before patch: allocation took ~32 seconds.
  • After patch: allocation takes ~17 seconds (i.e., about 15 seconds less).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Oct 24 2018, 2:59 PM
Owners added a subscriber: Restricted Owners Package.Oct 24 2018, 2:59 PM
epriestley requested review of this revision.Oct 24 2018, 3:00 PM
amckinley accepted this revision.Oct 26 2018, 1:46 AM
amckinley added inline comments.
src/applications/drydock/worker/DrydockWorker.php
245

"resource"

This revision is now accepted and ready to land.Oct 26 2018, 1:46 AM
  • Fix spelling mistake.
This revision was automatically updated to reflect the committed changes.