Page MenuHomePhabricator

After a Drydock lease triggers a resource to be reclaimed, stop it from triggering another reclaim until the first one completes
ClosedPublic

Authored by epriestley on Oct 24 2018, 4:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 9, 3:38 AM
Unknown Object (File)
Feb 7 2024, 4:29 PM
Unknown Object (File)
Feb 3 2024, 7:40 PM
Unknown Object (File)
Jan 25 2024, 1:23 AM
Unknown Object (File)
Jan 17 2024, 2:48 AM
Unknown Object (File)
Dec 22 2023, 12:33 AM
Unknown Object (File)
Dec 21 2023, 12:45 PM
Unknown Object (File)
Dec 14 2023, 7:57 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19752. Ref T13210. If resources take a long time to reclaim/destroy (normally, more than 15 seconds) a single new lease may update several times during the reclaim/destroy process and end up reclaiming multiple resources.

Instead: after a lease triggers a reclaim, prevent it from triggering another reclaim as long as the resource it is reclaiming hasn't finished its reclaim/destroy cycle. Basically, each lease only gets to destroy one resource at a time.

Test Plan
  • Added a sleep(120) to destroyResource() to simulate a long reclaim/destroy cycle.
  • Allocated A, A, A working copies. Leased a B working copy.
  • Before patch: saw "B" lease destroy all three "A" working copies after ~0, ~15, and ~30 seconds, then build a new "B" resource after ~120 seconds (when the first reclaim/destroy finished).
  • After patch: saw "B" lease destroy one "A" working copy after ~0 seconds, then wait patiently until it finished up, then build a new "B" resource.

Diff Detail

Repository
rP Phabricator
Branch
drydock4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21031
Build 28572: Run Core Tests
Build 28571: arc lint + arc unit