Page MenuHomePhabricator

In "bin/drydock lease", take a JSON "--attributes" so we can accept complex values
ClosedPublic

Authored by epriestley on Oct 24 2018, 2:22 PM.
Tags
None
Referenced Files
F15473382: D19751.id47201.diff
Sat, Apr 5, 9:32 PM
F15473381: D19751.id47183.diff
Sat, Apr 5, 9:32 PM
F15473367: D19751.id.diff
Sat, Apr 5, 9:20 PM
F15465574: D19751.diff
Wed, Apr 2, 8:50 PM
F15424945: D19751.id47201.diff
Sun, Mar 23, 1:18 AM
F15385515: D19751.id.diff
Fri, Mar 14, 10:45 PM
F15380029: D19751.diff
Fri, Mar 14, 1:00 AM
F15324379: D19751.diff
Mar 7 2025, 1:30 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19750. See T13210. The bin/drydock lease command makes it easier to request ad-hoc leases, but currently takes lease attributes in the form --attributes x=y,a=b.

This was okay for all leases at the time, but doesn't really work for modern WorkingCopy resources since they take a repositories.map which has a dictionary as a value. You can't specify that with repositories.map=....

Instead, point --attributes at a JSON file or use --attributes - to read from stdin.

Test Plan

Used --attributes with a file and stdin to allocate working copy leases with repositories.

Diff Detail

Repository
rP Phabricator
Branch
drydock2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21028
Build 28566: Run Core Tests
Build 28565: arc lint + arc unit