Page MenuHomePhabricator

In "bin/drydock lease", take a JSON "--attributes" so we can accept complex values
ClosedPublic

Authored by epriestley on Oct 24 2018, 2:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 9:17 AM
Unknown Object (File)
Mon, May 6, 9:45 AM
Unknown Object (File)
Fri, May 3, 9:10 AM
Unknown Object (File)
Tue, Apr 30, 10:10 PM
Unknown Object (File)
Thu, Apr 25, 2:50 AM
Unknown Object (File)
Fri, Apr 19, 10:00 AM
Unknown Object (File)
Fri, Apr 19, 4:57 AM
Unknown Object (File)
Fri, Apr 19, 2:55 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19750. See T13210. The bin/drydock lease command makes it easier to request ad-hoc leases, but currently takes lease attributes in the form --attributes x=y,a=b.

This was okay for all leases at the time, but doesn't really work for modern WorkingCopy resources since they take a repositories.map which has a dictionary as a value. You can't specify that with repositories.map=....

Instead, point --attributes at a JSON file or use --attributes - to read from stdin.

Test Plan

Used --attributes with a file and stdin to allocate working copy leases with repositories.

Diff Detail

Repository
rP Phabricator
Branch
drydock2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21028
Build 28566: Run Core Tests
Build 28565: arc lint + arc unit