Page MenuHomePhabricator

In "bin/drydock lease", take a JSON "--attributes" so we can accept complex values
ClosedPublic

Authored by epriestley on Oct 24 2018, 2:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 7:35 PM
Unknown Object (File)
Thu, Nov 14, 5:51 PM
Unknown Object (File)
Sun, Nov 10, 11:13 PM
Unknown Object (File)
Thu, Nov 7, 2:40 AM
Unknown Object (File)
Wed, Oct 23, 4:56 AM
Unknown Object (File)
Wed, Oct 23, 4:10 AM
Unknown Object (File)
Wed, Oct 23, 3:38 AM
Unknown Object (File)
Oct 21 2024, 11:52 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19750. See T13210. The bin/drydock lease command makes it easier to request ad-hoc leases, but currently takes lease attributes in the form --attributes x=y,a=b.

This was okay for all leases at the time, but doesn't really work for modern WorkingCopy resources since they take a repositories.map which has a dictionary as a value. You can't specify that with repositories.map=....

Instead, point --attributes at a JSON file or use --attributes - to read from stdin.

Test Plan

Used --attributes with a file and stdin to allocate working copy leases with repositories.

Diff Detail

Repository
rP Phabricator
Branch
drydock2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21028
Build 28566: Run Core Tests
Build 28565: arc lint + arc unit