Paths

Table of Contentst

Differential D19658

Enrich "diffusion.commit.search" with identity, status, and message information
ClosedPublic
Actions

Authored by epriestley on Sep 11 2018, 2:52 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13197: 2018 Week 37 Bonus Content

Commits

rP8268abcb7880: Enrich "diffusion.commit.search" with identity, status, and message information

Summary

Depends on D19657. Ref T13197. See PHI841.

This enriches the results from diffusion.commit.search with information similar to the information returned by the "commits" attachment from differential.diff.search.

Also include unreachable, imported, message, audit status, and repository PHID.

Test Plan

Called diffusion.commit.search and reviewed the results, which looked sensible.

Diff Detail

Repository

rP Phabricator

Branch

audit14

Lint

Lint OK

Unit

Unit Tests OK

Build Status

Buildable 20788
Build 28270: Run Core Tests
Build 28269: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 11 2018, 2:52 PM

Harbormaster completed remote builds in B20788: Diff 46978.Sep 11 2018, 2:53 PM

epriestley requested review of this revision.Sep 11 2018, 2:53 PM

amckinley accepted this revision.Sep 11 2018, 9:33 PM

This revision is now accepted and ready to land.Sep 11 2018, 9:33 PM

Closed by commit rP8268abcb7880: Enrich "diffusion.commit.search" with identity, status, and message information (authored by epriestley). · Explain WhySep 12 2018, 7:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

query/

PhabricatorCommitSearchEngine.php

1 line

diffusion/

DiffusionCommitAuditStatus.php

10 lines

repository/

storage/

PhabricatorRepositoryCommit.php

98 lines

Diff 46978

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

View Options

src/applications/diffusion/DiffusionCommitAuditStatus.php

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Enrich "diffusion.commit.search" with identity, status, and message informationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46978

src/applications/audit/query/PhabricatorCommitSearchEngine.php

src/applications/diffusion/DiffusionCommitAuditStatus.php

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Enrich "diffusion.commit.search" with identity, status, and message information
ClosedPublic
Actions

Revision Contents
Changeset List