Paths

Table of Contentst

Differential D19657

Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"; remove "MODERN_"
ClosedPublic
Actions

Authored by epriestley on Sep 11 2018, 2:22 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13197: 2018 Week 37 Bonus Content

Commits

rPc7e7b63f155f: Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"…

Summary

Depends on D19656. Ref T13197. See PHI851.

This class is now a real object, so get rid of the "Constants" part of the name.
Rename it for greater consistency with other modern objects.
Get rid of the MODERN_ tag now that the old constants are gone.

Test Plan

Bunch of grep, browsed around.

Diff Detail

Repository

rP Phabricator

Branch

audit12

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20787
Build 28268: Run Core Tests
Build 28267: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 11 2018, 2:22 PM

Harbormaster completed remote builds in B20787: Diff 46977.Sep 11 2018, 2:24 PM

epriestley requested review of this revision.Sep 11 2018, 2:24 PM

epriestley added a child revision: D19658: Enrich "diffusion.commit.search" with identity, status, and message information.Sep 11 2018, 2:52 PM

amckinley accepted this revision.Sep 12 2018, 4:07 AM

This revision is now accepted and ready to land.Sep 12 2018, 4:07 AM

Closed by commit rPc7e7b63f155f: Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"… (authored by epriestley). · Explain WhySep 12 2018, 7:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

audit/

conduit/

AuditQueryConduitAPIMethod.php

10 lines

constants/

PhabricatorAuditCommitStatusConstants.php

query/

PhabricatorCommitSearchEngine.php

6 lines

	diffusion/	DiffusionCommitAuditStatus.php/
	audit/	constants/


	PhabricatorAuditCommitStatusConstants.php

38 lines

diffusion/

query/

DiffusionCommitQuery.php

2 lines

xaction/

DiffusionCommitConcernTransaction.php

3 lines

DiffusionCommitStateTransaction.php

22 lines

DiffusionCommitVerifyTransaction.php

3 lines

owners/

controller/

PhabricatorOwnersDetailController.php

3 lines

repository/

storage/

PhabricatorRepositoryCommit.php

18 lines

Diff 46977

View Options

src/__phutil_library_map__.php

View Options

src/applications/audit/conduit/AuditQueryConduitAPIMethod.php

View Options

src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

View Options

src/applications/diffusion/DiffusionCommitAuditStatus.php

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

View Options

src/applications/diffusion/xaction/DiffusionCommitConcernTransaction.php

View Options

src/applications/diffusion/xaction/DiffusionCommitStateTransaction.php

View Options

src/applications/diffusion/xaction/DiffusionCommitVerifyTransaction.php

View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"; remove "MODERN_"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46977

src/__phutil_library_map__.php

src/applications/audit/conduit/AuditQueryConduitAPIMethod.php

src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php

src/applications/audit/query/PhabricatorCommitSearchEngine.php

src/applications/diffusion/DiffusionCommitAuditStatus.php

src/applications/diffusion/query/DiffusionCommitQuery.php

src/applications/diffusion/xaction/DiffusionCommitConcernTransaction.php

src/applications/diffusion/xaction/DiffusionCommitStateTransaction.php

src/applications/diffusion/xaction/DiffusionCommitVerifyTransaction.php

src/applications/owners/controller/PhabricatorOwnersDetailController.php

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"; remove "MODERN_"
ClosedPublic
Actions

Revision Contents
Changeset List