Details
Details
- Reviewers
amckinley - Maniphest Tasks
- T13197: 2018 Week 37 Bonus Content
- Commits
- rPd63281cc549e: Migrate remaining Audit database status constants
- Ran migrations.
- Spot-checked the database for sanity.
- Ran some different queries, got unchanged results from before migration.
- Reviewed historic audit state transactions, and accepted/raised concern on new audits. All state transactions appeared to generate properly.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- audit10
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 20785 Build 28264: Run Core Tests Build 28263: arc lint + arc unit
Event Timeline
resources/sql/autopatches/20180910.audit.04.xactions.php | ||
---|---|---|
22 | No need to update old_value? |
resources/sql/autopatches/20180910.audit.04.xactions.php | ||
---|---|---|
22 | Oh! Nothing ever uses the old value so I thought it wasn't populated, but I went back and double checked and it actually is. So we don't need to, but I'll update this so we do just for completeness. |
Comment Actions
- Also migrate old values.
- Re-ran migration with bin/storage upgrade -f --apply ... --trace, saw reasonable-looking queries and ended up in a sensible database state.