Allow `willLintPaths` and `didLintPaths` to be overridden
ClosedPublic
Actions

Authored by joshuaspence on Sep 3 2018, 5:24 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC30b7835c37b5: Allow `willLintPaths` and `didLintPaths` to be overridden

Summary

I'm not sure if the upstream will be interested in this change, but we are writing a linter which works by running an external command on the entire repository. This can't be done with ArcanistExternalLinter at the moment, which meant that we ended up copy-pasting most of ArcanistFutureLinter. This would be a lot easier if we could override willLintPaths and didLintPaths, but these methods are currently marked as final. An alternative solution would be some sort of ArcanistLinter::transformPath method.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 20726
Build 28174: Run Core Tests
Build 28173: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	409 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("") Assertion failed, expected values to be equal (at ArcanistLinterTestCase.php:168): Some linters failed: - CommandException: Command failed with error #1! COMMAND
	1,148 ms	ArcanistRuboCopLinterTestCase::Unknown Unit Message ("") In 'warning.lint-test', expected lint to raise warning on line 1 at char 11, but no warning was raised. Actually raised: No messages.
	31 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("") 7 assertions passed.
	12 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("") 3 assertions passed.
	12 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("") 4 assertions passed.
		View Full Test Results (2 Failed · 194 Passed · 62 Skipped)

Event Timeline

joshuaspence created this revision.Sep 3 2018, 5:24 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 3 2018, 5:24 AM

Harbormaster completed remote builds in B20726: Diff 46920.Sep 3 2018, 5:24 AM

joshuaspence requested review of this revision.Sep 3 2018, 5:24 AM

Herald added a subscriber: Korvin. · View Herald TranscriptSep 3 2018, 5:24 AM

I believe it is nearly the end of days for this version of arc so I'm fine with just letting some stuff like this in.

This revision is now accepted and ready to land.Sep 4 2018, 3:30 PM

In D19630#242798, @epriestley wrote:

I believe it is nearly the end of days for this version of arc so I'm fine with just letting some stuff like this in.

What do you mean by this exactly?

faulconbridge added a subscriber: faulconbridge.Sep 4 2018, 8:25 PM