Page MenuHomePhabricator

If "branch" is provided to "diffusion.branchquery", use it as the "<pattern>" argument to "git branch --contains ..."
ClosedPublic

Authored by epriestley on Jun 21 2018, 10:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 2, 8:17 PM
Unknown Object (File)
Sat, Jun 13, 8:26 PM
Unknown Object (File)
Mar 14 2026, 9:26 PM
Unknown Object (File)
Mar 14 2026, 5:37 PM
Unknown Object (File)
Oct 4 2025, 4:59 AM
Unknown Object (File)
Sep 30 2025, 10:07 AM
Unknown Object (File)
Sep 25 2025, 8:13 AM
Unknown Object (File)
Sep 16 2025, 4:41 AM
Subscribers
None

Details

Summary

Ref T13151. See PHI720. If you want to test if commit X appears on specific branch Y, git branch --contains X -- Y is faster than (effectively) git branch --contains X | grep Y.

Since this call has a "branch" parameter anyway, use it as the pattern argument if provided.

Test Plan
  • Called the API method with no parameters, got all branches.
  • Called the API method with master, got just master.
  • Called the API method with maste*, got master. This behavior is not officially supported and may change in the future.
  • Viewed a commit, still saw all branches.
    • Grepped for diffusion.branchquery and verified that no remaining callsites pass a default "branch" parameter.

Diff Detail

Repository
rP Phabricator
Branch
branch1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20435
Build 27754: Run Core Tests
Build 27753: arc lint + arc unit