Page MenuHomePhabricator

Add an explicit "null" to a missed `diffusion.branchquery` callsite to fix Diffusion "Branches" page
ClosedPublic

Authored by epriestley on Jul 21 2018, 12:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 7:35 PM
Unknown Object (File)
Wed, Mar 20, 2:15 PM
Unknown Object (File)
Feb 12 2024, 5:01 PM
Unknown Object (File)
Jan 31 2024, 9:20 AM
Unknown Object (File)
Jan 22 2024, 8:12 AM
Unknown Object (File)
Dec 27 2023, 8:54 PM
Unknown Object (File)
Dec 15 2023, 2:51 PM
Unknown Object (File)
Dec 13 2023, 12:51 AM
Subscribers
None

Details

Summary

See PHI775. See D19499. Originally, see PHI720.

D19499 broke the standalone "Branches" page for commits. Normally, you reach this by taking these steps:

  • View a commit which is contained by 11 or more branches.
  • Click the "More Branches..." link in the "Branches" field.
  • You should be taken to a list of all branches which contain the commit.

The change to the 'branch' parameter was adjusted in the query that builds the "x, y, z, More Branches..." list, but not on the actual "Branches" list with the full list. Adjust it.

Test Plan
  • Set display limit to 1, viewed a commit on "master" and "stable", clicked "More Branches".
  • Before: saw only "master".
  • After: saw both "master" and "stable".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable