Page MenuHomePhabricator

If "branch" is provided to "diffusion.branchquery", use it as the "<pattern>" argument to "git branch --contains ..."
ClosedPublic

Authored by epriestley on Jun 21 2018, 10:31 PM.
Tags
None
Referenced Files
F14775905: D19499.diff
Fri, Jan 24, 3:28 AM
Unknown Object (File)
Wed, Jan 22, 6:38 PM
Unknown Object (File)
Sun, Jan 19, 2:01 PM
Unknown Object (File)
Sat, Jan 18, 3:28 AM
Unknown Object (File)
Fri, Jan 17, 4:49 PM
Unknown Object (File)
Sun, Jan 12, 7:25 AM
Unknown Object (File)
Tue, Jan 7, 7:43 AM
Unknown Object (File)
Sun, Dec 29, 11:56 PM
Subscribers
None

Details

Summary

Ref T13151. See PHI720. If you want to test if commit X appears on specific branch Y, git branch --contains X -- Y is faster than (effectively) git branch --contains X | grep Y.

Since this call has a "branch" parameter anyway, use it as the pattern argument if provided.

Test Plan
  • Called the API method with no parameters, got all branches.
  • Called the API method with master, got just master.
  • Called the API method with maste*, got master. This behavior is not officially supported and may change in the future.
  • Viewed a commit, still saw all branches.
    • Grepped for diffusion.branchquery and verified that no remaining callsites pass a default "branch" parameter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable