Page MenuHomePhabricator

If "branch" is provided to "diffusion.branchquery", use it as the "<pattern>" argument to "git branch --contains ..."
ClosedPublic

Authored by epriestley on Jun 21 2018, 10:31 PM.
Tags
None
Referenced Files
F12843787: D19499.id46629.diff
Thu, Mar 28, 11:02 PM
Unknown Object (File)
Wed, Mar 6, 3:38 PM
Unknown Object (File)
Thu, Feb 29, 1:35 PM
Unknown Object (File)
Feb 10 2024, 4:50 PM
Unknown Object (File)
Jan 30 2024, 10:30 AM
Unknown Object (File)
Jan 20 2024, 4:43 PM
Unknown Object (File)
Jan 16 2024, 11:30 PM
Unknown Object (File)
Jan 7 2024, 5:00 PM
Subscribers
None

Details

Summary

Ref T13151. See PHI720. If you want to test if commit X appears on specific branch Y, git branch --contains X -- Y is faster than (effectively) git branch --contains X | grep Y.

Since this call has a "branch" parameter anyway, use it as the pattern argument if provided.

Test Plan
  • Called the API method with no parameters, got all branches.
  • Called the API method with master, got just master.
  • Called the API method with maste*, got master. This behavior is not officially supported and may change in the future.
  • Viewed a commit, still saw all branches.
    • Grepped for diffusion.branchquery and verified that no remaining callsites pass a default "branch" parameter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable