Page MenuHomePhabricator

If "branch" is provided to "diffusion.branchquery", use it as the "<pattern>" argument to "git branch --contains ..."
ClosedPublic

Authored by epriestley on Jun 21 2018, 10:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 9:31 AM
Unknown Object (File)
Mon, Nov 4, 3:41 AM
Unknown Object (File)
Sat, Oct 26, 1:01 PM
Unknown Object (File)
Oct 17 2024, 5:10 PM
Unknown Object (File)
Oct 14 2024, 9:49 PM
Unknown Object (File)
Oct 13 2024, 5:10 AM
Unknown Object (File)
Oct 13 2024, 5:09 AM
Unknown Object (File)
Oct 13 2024, 3:54 AM
Subscribers
None

Details

Summary

Ref T13151. See PHI720. If you want to test if commit X appears on specific branch Y, git branch --contains X -- Y is faster than (effectively) git branch --contains X | grep Y.

Since this call has a "branch" parameter anyway, use it as the pattern argument if provided.

Test Plan
  • Called the API method with no parameters, got all branches.
  • Called the API method with master, got just master.
  • Called the API method with maste*, got master. This behavior is not officially supported and may change in the future.
  • Viewed a commit, still saw all branches.
    • Grepped for diffusion.branchquery and verified that no remaining callsites pass a default "branch" parameter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable