Page MenuHomePhabricator

Truncate package names in diff table of contents views
ClosedPublic

Authored by epriestley on Jun 7 2018, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 1:52 AM
Unknown Object (File)
Wed, Nov 20, 7:41 PM
Unknown Object (File)
Sat, Nov 16, 7:29 AM
Unknown Object (File)
Mon, Nov 11, 8:00 PM
Unknown Object (File)
Sat, Nov 9, 3:17 PM
Unknown Object (File)
Fri, Nov 8, 1:00 AM
Unknown Object (File)
Sat, Oct 26, 10:51 AM
Unknown Object (File)
Oct 21 2024, 4:56 AM
Subscribers
None

Details

Summary

Ref T13151. See PHI654. Depends on D19477. If you have long package names, the table of contents (e.g., in Differential) can end up expanding to be gigantic.

Getting tables to behave nicely is hard (or, at least, I can't figure it out after spending a decent amount of time on it; see also AphrontTableView::renderSingleDisplayLine()). I tried a bunch of things and Googled for a bit but didn't make any progress on finding a CSS solution. Just truncate the package names to get reasonable behavior without falling down any kind of CSS rabbit hole.

Test Plan
  • Created a package named "Very long package name...".
  • Created a package named "MMMMMMMMMMMMMMMMMMMMMM...".
  • Had them own a file in a Differential revision, viewed that revision.
  • Before: table is pushed out to several times the browser window width and everything is kind of a mess.
  • After: package names get truncated to something reasonable.

Screen Shot 2018-06-07 at 11.55.47 AM.png (620×1 px, 128 KB)

Diff Detail

Repository
rP Phabricator
Branch
toc1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20386
Build 27685: Run Core Tests
Build 27684: arc lint + arc unit