Page MenuHomePhabricator

Improve string truncation behavior for strings truncated in a very long word
ClosedPublic

Authored by epriestley on Jun 7 2018, 6:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 3:13 PM
Unknown Object (File)
Thu, Dec 19, 12:50 AM
Unknown Object (File)
Mon, Dec 16, 8:08 PM
Unknown Object (File)
Thu, Dec 12, 7:51 AM
Unknown Object (File)
Wed, Dec 11, 3:29 AM
Unknown Object (File)
Tue, Dec 10, 6:58 PM
Unknown Object (File)
Sat, Dec 7, 4:49 PM
Unknown Object (File)
Dec 4 2024, 7:25 AM
Subscribers
None

Details

Summary

Ref T13151. See PHI654. When truncating strings like package names in the form "X: YYYYYYYYYYYY", we currently render "X...".

A better rendering in this case is "X: YYYYYY...", where we chop the long word in the middle.

Tweak the logic a bit to handle this case better.

This will support improving the display behavior of long package names in the table of contents view.

Test Plan

Added/modified unit tests, got a clean result.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable