Page MenuHomePhabricator

Truncate package names in diff table of contents views
ClosedPublic

Authored by epriestley on Jun 7 2018, 7:00 PM.
Tags
None
Referenced Files
F13088833: D19478.diff
Thu, Apr 25, 1:34 AM
Unknown Object (File)
Fri, Apr 19, 7:46 PM
Unknown Object (File)
Thu, Apr 11, 9:10 AM
Unknown Object (File)
Thu, Apr 4, 7:16 PM
Unknown Object (File)
Sat, Mar 30, 1:51 AM
Unknown Object (File)
Jan 25 2024, 9:29 AM
Unknown Object (File)
Jan 9 2024, 3:53 AM
Unknown Object (File)
Dec 27 2023, 12:48 PM
Subscribers
None

Details

Summary

Ref T13151. See PHI654. Depends on D19477. If you have long package names, the table of contents (e.g., in Differential) can end up expanding to be gigantic.

Getting tables to behave nicely is hard (or, at least, I can't figure it out after spending a decent amount of time on it; see also AphrontTableView::renderSingleDisplayLine()). I tried a bunch of things and Googled for a bit but didn't make any progress on finding a CSS solution. Just truncate the package names to get reasonable behavior without falling down any kind of CSS rabbit hole.

Test Plan
  • Created a package named "Very long package name...".
  • Created a package named "MMMMMMMMMMMMMMMMMMMMMM...".
  • Had them own a file in a Differential revision, viewed that revision.
  • Before: table is pushed out to several times the browser window width and everything is kind of a mess.
  • After: package names get truncated to something reasonable.

Screen Shot 2018-06-07 at 11.55.47 AM.png (620×1 px, 128 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable