Page MenuHomePhabricator

Improve string truncation behavior for strings truncated in a very long word
ClosedPublic

Authored by epriestley on Jun 7 2018, 6:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 9:16 AM
Unknown Object (File)
Mon, Nov 18, 5:20 AM
Unknown Object (File)
Wed, Nov 13, 6:57 PM
Unknown Object (File)
Sun, Nov 10, 2:21 AM
Unknown Object (File)
Sat, Nov 9, 3:17 PM
Unknown Object (File)
Sat, Nov 9, 3:17 PM
Unknown Object (File)
Sat, Nov 9, 3:17 PM
Unknown Object (File)
Wed, Nov 6, 12:13 AM
Subscribers
None

Details

Summary

Ref T13151. See PHI654. When truncating strings like package names in the form "X: YYYYYYYYYYYY", we currently render "X...".

A better rendering in this case is "X: YYYYYY...", where we chop the long word in the middle.

Tweak the logic a bit to handle this case better.

This will support improving the display behavior of long package names in the table of contents view.

Test Plan

Added/modified unit tests, got a clean result.

Diff Detail

Repository
rPHU libphutil
Branch
trunc1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20385
Build 27683: Run Core Tests
Build 27682: arc lint + arc unit