In "arc patch", update submodules slightly later
ClosedPublic
Actions

Authored by epriestley on Jun 7 2018, 4:51 PM.

Details

Reviewers

amckinley
jmeador

Maniphest Tasks

T13151: Plans: 2018 Week 23 - Week 30 Bonus Content

Commits

rARCdf7313bdf2a3: In "arc patch", update submodules slightly later

Summary

Ref T13151. See PHI648. With arc patch --nobranch, we update submodules a little too early.

I believe it is safe to just update them a little later, after the intermediate branch management logic runs.

Test Plan

Ran arc patch --nobranch, saw submodule update run later. Not 100% sure this doesn't cause weird issues, but I can't anticipate any.

Diff Detail

Repository

rARC Arcanist

Branch

patch1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20382
Build 27678: Run Core Tests
Build 27677: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 7 2018, 4:51 PM

Harbormaster completed remote builds in B20382: Diff 46578.Jun 7 2018, 4:51 PM

epriestley requested review of this revision.Jun 7 2018, 4:51 PM

jmeador accepted this revision.Jun 7 2018, 5:29 PM

This revision is now accepted and ready to land.Jun 7 2018, 5:29 PM

Closed by commit rARCdf7313bdf2a3: In "arc patch", update submodules slightly later (authored by epriestley). · Explain WhyJun 7 2018, 7:03 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D20253: Fix a case where "arc patch" could skip submodule changes.Mar 6 2019, 6:45 PM

epriestley mentioned this in rARC73804f003972: Fix a case where "arc patch" could skip submodule changes.Mar 7 2019, 8:52 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistPatchWorkflow.php

8 lines

Diff 46578

View Options

src/workflow/ArcanistPatchWorkflow.php

In "arc patch", update submodules slightly laterClosedPublicActions