Page MenuHomePhabricator
Differential D19356

Give getAlmanacServiceURI() an "options" parameter to prepare for read-only devices
ClosedPublic
Actions

Authored by epriestley on Apr 12 2018, 8:59 PM.
Tags
None
Referenced Files
F15534989: D19356.id46305.diff
Thu, Apr 24, 2:55 AM
F15525905: D19356.id46315.diff
Mon, Apr 21, 5:43 PM
F15521239: D19356.id.diff
Sun, Apr 20, 12:30 PM
F15517913: D19356.diff
Sat, Apr 19, 9:28 AM
F15469771: D19356.diff
Fri, Apr 4, 4:30 PM
F15453035: D19356.id46305.diff
Sat, Mar 29, 8:55 AM
F15427616: D19356.id46315.diff
Mar 23 2025, 3:11 PM
F15403825: D19356.diff
Mar 18 2025, 4:59 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T10883: Allow repository cluster nodes to be read-only
T13120: Plans: 2018 Week 15 Bonus Content
Commits
rP7c7e6d555b3f: Give getAlmanacServiceURI() an "options" parameter to prepare for read-only…
Summary

Depends on D19355. Ref T10883. Ref T13120. Rather than adding a million parameters here, wrap the selector-parameters in an $options.

The next change adds a new "writable" option to support forcing selection of writable hosts.

Test Plan

Pulled and pushed via HTTP and SSH, viewed repositories via Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
writable2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20122
Build 27296: Run Core Tests
Build 27295: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
8 lines
ssh/
6 lines
repository/
storage/
24 lines

Diff 46305

View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility