Turn the "closed" property on cluster repositories into a nice boolean
ClosedPublic
Actions

Authored by epriestley on Apr 12 2018, 8:38 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T10883: Allow repository cluster nodes to be read-only
T13120: Plans: 2018 Week 15 Bonus Content

Commits

rP6f810d781308: Turn the "closed" property on cluster repositories into a nice boolean

Summary

Ref T10883. Ref T13120. There's an existing "closed" property on repository services that stops new repositories from being allocated there.

Turn it into a nice boolean.

Test Plan

Toggled the value on/off using a nice <select /> with helpful labels instead of a text area.

Diff Detail

Repository

rP Phabricator

Branch

writable1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20121
Build 27294: Run Core Tests
Build 27293: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 12 2018, 8:38 PM

Harbormaster completed remote builds in B20121: Diff 46304.Apr 12 2018, 8:39 PM

epriestley requested review of this revision.Apr 12 2018, 8:39 PM

amckinley accepted this revision.Apr 12 2018, 8:41 PM

This revision is now accepted and ready to land.Apr 12 2018, 8:41 PM

epriestley added a child revision: D19356: Give getAlmanacServiceURI() an "options" parameter to prepare for read-only devices.Apr 12 2018, 8:59 PM

Closed by commit rP6f810d781308: Turn the "closed" property on cluster repositories into a nice boolean (authored by epriestley). · Explain WhyApr 12 2018, 11:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

servicetype/

AlmanacClusterRepositoryServiceType.php

6 lines

Diff 46304

View Options

src/applications/almanac/servicetype/AlmanacClusterRepositoryServiceType.php

Turn the "closed" property on cluster repositories into a nice booleanClosedPublicActions