Differential D19310

Make DocumentEngine source line linking behavior better when blame is shown
ClosedPublic
Actions

Authored by epriestley on Apr 9 2018, 12:16 PM.

Details

Reviewers: None
Maniphest Tasks: T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits: rP11664277b33d: Make DocumentEngine source line linking behavior better when blame is shown

Summary

Ref T13105. The line linker behavior currently has trouble identifying the line number when blame is active. Improve this, albeit not the most cleanly.

Test Plan

Selected lines with blame on.

Diff Detail

Repository

rP Phabricator

Branch

dfile9

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20032
Build 27164: Run Core Tests
Build 27163: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 9 2018, 12:16 PM

Harbormaster completed remote builds in B20032: Diff 46208.Apr 9 2018, 12:17 PM

epriestley requested review of this revision.Apr 9 2018, 12:17 PM

epriestley added a child revision: D19311: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly.Apr 9 2018, 12:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2018, 1:09 PM

Closed by commit rP11664277b33d: Make DocumentEngine source line linking behavior better when blame is shown (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

16 lines

webroot/

rsrc/

js/

core/

behavior-line-linker.js

17 lines

Diff 46208

View Options

resources/celerity/map.php