Page MenuHomePhabricator

Improve live Harbormaster log follow behaviors
ClosedPublic

Authored by epriestley on Mar 1 2018, 6:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 8:37 AM
Unknown Object (File)
Fri, Nov 15, 9:54 PM
Unknown Object (File)
Tue, Nov 12, 5:17 AM
Unknown Object (File)
Sat, Nov 9, 8:31 AM
Unknown Object (File)
Fri, Nov 8, 11:15 AM
Unknown Object (File)
Mon, Nov 4, 2:34 PM
Unknown Object (File)
Mon, Nov 4, 2:19 PM
Unknown Object (File)
Fri, Nov 1, 7:42 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19166. Ref T13088. When the user scrolls away from a followed log, break the focus lock.

Let users stop following a live log.

Show when lines are added more clearly.

Don't refresh quite as quickly give users a better shot at clicking the stop button.

These behaviors can probably be refined but are at least more plausible and less actively user-hostile than the first version of this behavior was.

Test Plan

Used write-log --rate to write a large log slowly. Clicked "Follow Log", followed for a bit. Scrolled away, still got live updates but no more scroll lock. Clicked stop, no more updates.

Diff Detail

Repository
rP Phabricator
Branch
harbor6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19716
Build 26706: Run Core Tests
Build 26705: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Mar 1 2018, 6:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2018, 9:11 PM
This revision was automatically updated to reflect the committed changes.