Page MenuHomePhabricator

Prevent copying Harbormaster build log line numbers with CSS psuedocontent instead of ZWS
ClosedPublic

Authored by epriestley on Mar 1 2018, 4:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 22, 5:45 PM
Unknown Object (File)
Tue, Jan 21, 8:06 PM
Unknown Object (File)
Tue, Jan 21, 9:39 AM
Unknown Object (File)
Fri, Dec 27, 6:32 PM
Unknown Object (File)
Wed, Dec 25, 11:13 PM
Unknown Object (File)
Dec 20 2024, 11:01 PM
Unknown Object (File)
Dec 20 2024, 5:26 AM
Unknown Object (File)
Dec 19 2024, 8:51 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19165. Ref T13088. Currently, in other applications, we use Zero Width Spaces and Javascript "copy" listeners to prevent line numbers from being copied. This isn't terribly elegant.

Modern browsers support a second approach: using psuedo-elements with content. Try this in Harbormaster since it's conceptually cleaner, at least. One immediate drawback is that Command-F can't find this text either.

Test Plan

In Safari, Chrome and Firefox, highlighted ranges of lines and copy/pasted text. Got just text (no line numbers) in all cases.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable