Page MenuHomePhabricator

Support rendering arbitrary sections in the middle of a Harbormaster build log so links to line 3500 work
ClosedPublic

Authored by epriestley on Mar 1 2018, 3:12 PM.
Tags
None
Referenced Files
F13247700: D19163.diff
Thu, May 23, 9:48 PM
F13245521: D19163.diff
Thu, May 23, 6:04 AM
F13197338: D19163.diff
Mon, May 13, 12:06 AM
F13192817: D19163.diff
Sun, May 12, 9:48 AM
F13191504: D19163.diff
Sat, May 11, 9:45 PM
F13175642: D19163.diff
Wed, May 8, 6:23 AM
Unknown Object (File)
Fri, May 3, 9:16 AM
Unknown Object (File)
Thu, Apr 25, 2:54 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19162. Ref T13088. When a user links to $1234, we need to render a default view of the log with a piece at the head, a piece at the end, and a piece in the middle.

We also need to figure out the offset for line 1234, or multiple offsets for "1234-2345".

Since the logic views/reads mostly anticipated this it isn't too much of a mess, although there are a couple of bugs this exposes with view specifications that use combinations of parameters which were previously impossible.

Test Plan

Viewed a large log with no line marker. Viewed $1. Viewed $end. Viewed $35-40, etc. Expanded context around logs.

Diff Detail

Repository
rP Phabricator
Branch
harbor2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19712
Build 26698: Run Core Tests
Build 26697: arc lint + arc unit