Page MenuHomePhabricator

Move PhrictionContent from RemarkupInterface (deprecated) to PHUIRemarkupView
ClosedPublic

Authored by epriestley on Feb 15 2018, 12:46 PM.
Tags
None
Referenced Files
F13896326: D19093.diff
Sun, Oct 6, 1:04 AM
Unknown Object (File)
Mon, Sep 30, 2:16 AM
Unknown Object (File)
Mon, Sep 9, 11:24 AM
Unknown Object (File)
Fri, Sep 6, 2:22 AM
Unknown Object (File)
Fri, Sep 6, 2:22 AM
Unknown Object (File)
Fri, Sep 6, 2:22 AM
Unknown Object (File)
Sep 2 2024, 9:00 PM
Unknown Object (File)
Sep 2 2024, 6:56 AM
Subscribers
None

Details

Summary

Depends on D19092. Ref T13077. This modernizes markup rendering for PhrictionContent.

This is a little messy because table of contents generation isn't straightforward.

Test Plan

Viewed Phriction documents with and without 3+ headers, saw ToC vs no ToC. Edited/previewed documents. Grepped for affected symbols. Checked DarkConsole for sensible cache behavior.

Diff Detail

Repository
rP Phabricator
Branch
phriction2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19563
Build 26477: Run Core Tests
Build 26476: arc lint + arc unit