Page MenuHomePhabricator
Differential D19064

Make Harbormaster buildable status more of a nice flexible map and less of a bunch of switch statements
ClosedPublic
Actions

Authored by epriestley on Feb 12 2018, 7:09 PM.
Tags
None
Referenced Files
F13169986: D19064.diff
Tue, May 7, 8:58 AM
F13166099: D19064.diff
Tue, May 7, 5:53 AM
Unknown Object (File)
Fri, May 3, 3:33 AM
Unknown Object (File)
Mon, Apr 29, 3:23 PM
Unknown Object (File)
Wed, Apr 24, 11:18 PM
Unknown Object (File)
Fri, Apr 19, 7:20 PM
Unknown Object (File)
Sun, Apr 7, 10:58 PM
Unknown Object (File)
Mar 30 2024, 6:46 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction
Commits
rPf939a2b12ea3: Make Harbormaster buildable status more of a nice flexible map and less of a…
Summary

Depends on D19063. Ref T13054. Prepare for the addition of a new PREPARING status by getting rid of the "scattered mess of switch statements" pattern of status management.

Test Plan

Searched/browsed buildables. Viewed buildables. Viewed revisions. Grepped for all affected symbols.

Diff Detail

Repository
rP Phabricator
Branch
hrace3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19503
Build 26388: Run Core Tests
Build 26387: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
customfield/
4 lines
diffusion/
view/
7 lines
harbormaster/
conduit/
2 lines
constants/
82 lines
engine/
13 lines
event/
10 lines
query/
10 lines
storage/
78 lines
transactions/
storage/
14 lines

Diff 45700

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/customfield/DifferentialUnitField.php

Loading...
View Options

src/applications/diffusion/view/DiffusionView.php

Loading...
View Options

src/applications/harbormaster/conduit/HarbormasterQueryBuildablesConduitAPIMethod.php

Loading...
View Options

src/applications/harbormaster/constants/HarbormasterBuildableStatus.php

Loading...
View Options

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

Loading...
View Options

src/applications/harbormaster/event/HarbormasterUIEventListener.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility