Page MenuHomePhabricator

Make push log "flags", "reject code" human readable; add crumbs to pull/push logs
ClosedPublic

Authored by epriestley on Jan 30 2018, 9:35 PM.
Tags
None
Referenced Files
F14631994: D18973.id45501.diff
Fri, Jan 10, 6:59 PM
Unknown Object (File)
Sun, Jan 5, 10:39 AM
Unknown Object (File)
Tue, Dec 24, 8:40 PM
Unknown Object (File)
Sat, Dec 21, 11:10 PM
Unknown Object (File)
Sat, Dec 21, 5:24 PM
Unknown Object (File)
Sat, Dec 21, 5:32 AM
Unknown Object (File)
Thu, Dec 19, 5:30 PM
Unknown Object (File)
Tue, Dec 17, 9:23 AM
Subscribers
None

Details

Summary

Depends on D18972. Ref T13049.

Currently, the "flags" columns renders an inscrutible bitmask which you have to go hunt down in the code. Show a list of flags in human-readable text instead.

The "code" column renders a meaningless integer code. Show a text description instead.

The pull logs and push logs pages don't have a crumb to go back up out of the current query. Add one.

Test Plan

Viewed push logs, no more arcane numbers. Saw and clicked crumbs on each log page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable