Page MenuHomePhabricator

Make push log "flags", "reject code" human readable; add crumbs to pull/push logs
ClosedPublic

Authored by epriestley on Jan 30 2018, 9:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:18 AM
Unknown Object (File)
Fri, Apr 19, 7:14 PM
Unknown Object (File)
Sun, Apr 7, 6:34 AM
Unknown Object (File)
Fri, Apr 5, 11:39 AM
Unknown Object (File)
Mar 23 2024, 5:00 AM
Unknown Object (File)
Mar 11 2024, 12:01 AM
Unknown Object (File)
Feb 16 2024, 3:29 PM
Unknown Object (File)
Dec 23 2023, 1:46 PM
Subscribers
None

Details

Summary

Depends on D18972. Ref T13049.

Currently, the "flags" columns renders an inscrutible bitmask which you have to go hunt down in the code. Show a list of flags in human-readable text instead.

The "code" column renders a meaningless integer code. Show a text description instead.

The pull logs and push logs pages don't have a crumb to go back up out of the current query. Add one.

Test Plan

Viewed push logs, no more arcane numbers. Saw and clicked crumbs on each log page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable