Page MenuHomePhabricator

Make push log "flags", "reject code" human readable; add crumbs to pull/push logs
ClosedPublic

Authored by epriestley on Jan 30 2018, 9:35 PM.
Tags
None
Referenced Files
F15420317: D18973.id45505.diff
Fri, Mar 21, 1:03 PM
F15398660: D18973.diff
Mon, Mar 17, 1:09 AM
F15393920: D18973.id45505.diff
Sat, Mar 15, 11:16 PM
F15390167: D18973.diff
Sat, Mar 15, 5:58 AM
F15334646: D18973.diff
Sat, Mar 8, 11:09 AM
Unknown Object (File)
Sun, Mar 2, 4:16 PM
Unknown Object (File)
Mon, Feb 24, 8:58 PM
Unknown Object (File)
Feb 19 2025, 2:30 PM
Subscribers
None

Details

Summary

Depends on D18972. Ref T13049.

Currently, the "flags" columns renders an inscrutible bitmask which you have to go hunt down in the code. Show a list of flags in human-readable text instead.

The "code" column renders a meaningless integer code. Show a text description instead.

The pull logs and push logs pages don't have a crumb to go back up out of the current query. Add one.

Test Plan

Viewed push logs, no more arcane numbers. Saw and clicked crumbs on each log page.

Diff Detail

Repository
rP Phabricator
Branch
export9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19289
Build 26066: Run Core Tests
Build 26065: arc lint + arc unit