Page MenuHomePhabricator

Make push log "flags", "reject code" human readable; add crumbs to pull/push logs
ClosedPublic

Authored by epriestley on Jan 30 2018, 9:35 PM.
Tags
None
Referenced Files
F13254828: D18973.diff
Sat, May 25, 3:48 AM
F13234623: D18973.diff
Tue, May 21, 3:35 AM
F13229742: D18973.diff
Mon, May 20, 6:52 PM
F13215379: D18973.diff
Fri, May 17, 4:56 PM
F13197352: D18973.diff
Mon, May 13, 12:07 AM
F13181750: D18973.diff
Thu, May 9, 3:04 PM
F13178677: D18973.diff
Wed, May 8, 8:35 PM
F13175323: D18973.diff
Wed, May 8, 4:38 AM
Subscribers
None

Details

Summary

Depends on D18972. Ref T13049.

Currently, the "flags" columns renders an inscrutible bitmask which you have to go hunt down in the code. Show a list of flags in human-readable text instead.

The "code" column renders a meaningless integer code. Show a text description instead.

The pull logs and push logs pages don't have a crumb to go back up out of the current query. Add one.

Test Plan

Viewed push logs, no more arcane numbers. Saw and clicked crumbs on each log page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable