Page MenuHomePhabricator

Change the "can see remote address?" policy to "is administrator?" everywhere
ClosedPublic

Authored by epriestley on Jan 30 2018, 8:07 PM.
Tags
None
Referenced Files
F13091447: D18971.diff
Thu, Apr 25, 2:57 AM
Unknown Object (File)
Fri, Apr 19, 7:14 PM
Unknown Object (File)
Fri, Apr 12, 10:33 PM
Unknown Object (File)
Thu, Apr 11, 10:29 AM
Unknown Object (File)
Sun, Apr 7, 6:34 AM
Unknown Object (File)
Tue, Apr 2, 7:22 AM
Unknown Object (File)
Mar 23 2024, 4:59 AM
Unknown Object (File)
Feb 27 2024, 1:58 PM
Subscribers
None

Details

Summary

Depends on D18970. Ref T13049. Currently, the policy for viewing remote addresses is:

  • In activity logs: administrators.
  • In push and pull logs: users who can edit the corresponding repository.

This sort of makes sense, but is also sort of weird. Particularly, I think it's kind of hard to understand and predict, and hard to guess that this is the behavior we implement. The actual implementation is complex, too.

Instead, just use the rule "administrators can see remote addresses" consistently across all applications. This should generally be more strict than the old rule, because administrators could usually have seen everyone's address in the activity logs anyway. It's also simpler and more expected, and I don't really know of any legit use cases for the "repository editor" rule.

Test Plan

Viewed pull/push/activity logs as non-admin. Saw remote addresses as an admin, and none as a non-admin.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable