Page MenuHomePhabricator
Differential D18923

Set an explicit default value for the bulk action control
ClosedPublic
Actions

Authored by epriestley on Jan 24 2018, 11:29 PM.
Tags
None
Referenced Files
F13061270: D18923.diff
Fri, Apr 19, 7:09 PM
Unknown Object (File)
Wed, Apr 17, 5:41 PM
Unknown Object (File)
Wed, Apr 17, 5:39 PM
Unknown Object (File)
Sun, Apr 14, 10:50 AM
Unknown Object (File)
Thu, Apr 11, 7:09 PM
Unknown Object (File)
Thu, Apr 11, 7:06 AM
Unknown Object (File)
Thu, Apr 11, 7:06 AM
Unknown Object (File)
Sat, Apr 6, 5:39 PM
View All 91 Files
Subscribers
franjesus

Details

Reviewers
amckinley
Maniphest Tasks
T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support
Commits
rP1059fae6c9b6: Set an explicit default value for the bulk action control
Summary

Ref T13025. See https://discourse.phabricator-community.org/t/bulk-edit-no-actions-available/1011/1.

I'm not sure if this is what the user is seeing, but in Chrome, the <select /> does not automatically get set to the first valid value like it does in Safari.

Set it to the first valid value explicitly.

Test Plan

In Chrome, bulk editor previously hit a JS error when trying to read a bad action off the <select />. After patch, bulk edits go through cleanly.

Diff Detail

Repository
rP Phabricator
Branch
bulk1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19171
Build 25886: Run Core Tests
Build 25885: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 24 2018, 11:29 PM
Harbormaster completed remote builds in B19171: Diff 45390.Jan 24 2018, 11:31 PM
epriestley requested review of this revision.Jan 24 2018, 11:31 PM
amckinley accepted this revision.Jan 25 2018, 6:33 PM

FYI, there's a user in Z1336 who mentioned seeing something similar.

This revision is now accepted and ready to land.Jan 25 2018, 6:33 PM
Closed by commit rP1059fae6c9b6: Set an explicit default value for the bulk action control (authored by epriestley). · Explain WhyJan 25 2018, 6:42 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Jan 25 2018, 6:45 PM

Probably the same, although they also didn't include browser vendor/version or console output so who knows.

franjesus added a subscriber: franjesus.Jan 26 2018, 10:05 AM
In D18923#232270, @epriestley wrote:

Probably the same, although they also didn't include browser vendor/version or console output so who knows.

Both FF 52.6.0 (ESR) and Chrome 62.0.3202.94,

so I assumed it was not browser-specific. I tried to debug the Javascript but I'm not very good at it so eventually I gave up.

Sorry I couldn't be of more help :/

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
bulk/
6 lines

Diff 45390

View Options

src/applications/transactions/bulk/PhabricatorBulkEngine.php

Loading...
Phabricator · Built by Phacility