Page MenuHomePhabricator

Set an explicit default value for the bulk action control
ClosedPublic

Authored by epriestley on Jan 24 2018, 11:29 PM.

Details

Summary

Ref T13025. See https://discourse.phabricator-community.org/t/bulk-edit-no-actions-available/1011/1.

I'm not sure if this is what the user is seeing, but in Chrome, the <select /> does not automatically get set to the first valid value like it does in Safari.

Set it to the first valid value explicitly.

Test Plan

In Chrome, bulk editor previously hit a JS error when trying to read a bad action off the <select />. After patch, bulk edits go through cleanly.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 24 2018, 11:29 PM
epriestley requested review of this revision.Jan 24 2018, 11:31 PM
amckinley accepted this revision.Jan 25 2018, 6:33 PM

FYI, there's a user in Z1336 who mentioned seeing something similar.

This revision is now accepted and ready to land.Jan 25 2018, 6:33 PM
This revision was automatically updated to reflect the committed changes.

Probably the same, although they also didn't include browser vendor/version or console output so who knows.

Probably the same, although they also didn't include browser vendor/version or console output so who knows.

Both FF 52.6.0 (ESR) and Chrome 62.0.3202.94,

so I assumed it was not browser-specific. I tried to debug the Javascript but I'm not very good at it so eventually I gave up.

Sorry I couldn't be of more help :/