Page MenuHomePhabricator

Set an explicit default value for the bulk action control
ClosedPublic

Authored by epriestley on Jan 24 2018, 11:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 7:42 PM
Unknown Object (File)
Tue, Mar 5, 8:50 AM
Unknown Object (File)
Feb 19 2024, 7:43 PM
Unknown Object (File)
Feb 3 2024, 5:46 PM
Unknown Object (File)
Jan 25 2024, 1:27 AM
Unknown Object (File)
Jan 19 2024, 3:11 PM
Unknown Object (File)
Jan 2 2024, 8:43 AM
Unknown Object (File)
Dec 21 2023, 11:05 PM
Subscribers

Details

Summary

Ref T13025. See https://discourse.phabricator-community.org/t/bulk-edit-no-actions-available/1011/1.

I'm not sure if this is what the user is seeing, but in Chrome, the <select /> does not automatically get set to the first valid value like it does in Safari.

Set it to the first valid value explicitly.

Test Plan

In Chrome, bulk editor previously hit a JS error when trying to read a bad action off the <select />. After patch, bulk edits go through cleanly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

FYI, there's a user in Z1336 who mentioned seeing something similar.

This revision is now accepted and ready to land.Jan 25 2018, 6:33 PM
This revision was automatically updated to reflect the committed changes.

Probably the same, although they also didn't include browser vendor/version or console output so who knows.

Probably the same, although they also didn't include browser vendor/version or console output so who knows.

Both FF 52.6.0 (ESR) and Chrome 62.0.3202.94,

so I assumed it was not browser-specific. I tried to debug the Javascript but I'm not very good at it so eventually I gave up.

Sorry I couldn't be of more help :/