Page MenuHomePhabricator

Fix Mercurial commit history ordering
ClosedPublic

Authored by epriestley on Dec 5 2017, 1:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 7 2026, 2:23 AM
Unknown Object (File)
Apr 2 2026, 9:13 AM
Unknown Object (File)
Apr 2 2026, 3:39 AM
Unknown Object (File)
Mar 30 2026, 7:30 PM
Unknown Object (File)
Mar 29 2026, 5:47 AM
Unknown Object (File)
Feb 25 2026, 1:58 AM
Unknown Object (File)
Feb 3 2026, 1:52 PM
Unknown Object (File)
Feb 3 2026, 11:03 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/diffusion-observed-mercurial-repository-history-broken/825.

In D18769, I rewrote this from using the --branch flag (which is unsafe and does not function on branches named --config=x.y and such).

However, this rewrite accidentally changed the result order, which impacted Mercurial commit hisotry lists and graphs. Swap the order of the constraints so we get newest-to-oldest again, as expected.

Test Plan

Viewed a Mercurial repository's history graph, saw sensible chronology after the patch.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable