Page MenuHomePhabricator

Fix Mercurial commit history ordering
ClosedPublic

Authored by epriestley on Dec 5 2017, 1:38 PM.
Tags
None
Referenced Files
F18831180: D18817.id.diff
Sat, Oct 25, 11:31 AM
F18830357: D18817.id45157.diff
Sat, Oct 25, 6:29 AM
F18830356: D18817.id45152.diff
Sat, Oct 25, 6:29 AM
F18830355: D18817.id.diff
Sat, Oct 25, 6:29 AM
F18829678: D18817.diff
Fri, Oct 24, 11:46 PM
F18812680: D18817.diff
Mon, Oct 20, 11:29 AM
F18804174: D18817.diff
Sat, Oct 18, 6:32 AM
F18771370: D18817.id.diff
Wed, Oct 8, 7:22 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/diffusion-observed-mercurial-repository-history-broken/825.

In D18769, I rewrote this from using the --branch flag (which is unsafe and does not function on branches named --config=x.y and such).

However, this rewrite accidentally changed the result order, which impacted Mercurial commit hisotry lists and graphs. Swap the order of the constraints so we get newest-to-oldest again, as expected.

Test Plan

Viewed a Mercurial repository's history graph, saw sensible chronology after the patch.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable