Page MenuHomePhabricator

Fix Mercurial commit history ordering
ClosedPublic

Authored by epriestley on Dec 5 2017, 1:38 PM.
Tags
None
Referenced Files
F15452861: D18817.id45157.diff
Sat, Mar 29, 7:48 AM
F15451373: D18817.id.diff
Fri, Mar 28, 9:45 PM
F15446992: D18817.id.diff
Thu, Mar 27, 9:15 PM
F15441566: D18817.id45152.diff
Wed, Mar 26, 6:49 PM
F15430461: D18817.diff
Mon, Mar 24, 7:47 AM
F15402474: D18817.id45157.diff
Mon, Mar 17, 10:42 PM
F15333420: D18817.id45152.diff
Sat, Mar 8, 2:17 AM
F15333257: D18817.id45157.diff
Sat, Mar 8, 1:21 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/diffusion-observed-mercurial-repository-history-broken/825.

In D18769, I rewrote this from using the --branch flag (which is unsafe and does not function on branches named --config=x.y and such).

However, this rewrite accidentally changed the result order, which impacted Mercurial commit hisotry lists and graphs. Swap the order of the constraints so we get newest-to-oldest again, as expected.

Test Plan

Viewed a Mercurial repository's history graph, saw sensible chronology after the patch.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable