Page MenuHomePhabricator

Fix Mercurial commit history ordering
ClosedPublic

Authored by epriestley on Dec 5 2017, 1:38 PM.
Tags
None
Referenced Files
F18764483: D18817.diff
Tue, Oct 7, 6:19 AM
F18617308: D18817.id45152.diff
Sun, Sep 14, 8:53 PM
F18509204: D18817.id.diff
Sep 5 2025, 3:17 AM
F18503370: D18817.diff
Sep 4 2025, 11:02 PM
F18501865: D18817.diff
Sep 4 2025, 10:01 PM
F18404878: D18817.id45157.diff
Aug 29 2025, 10:53 PM
F18374593: D18817.diff
Aug 28 2025, 8:59 AM
F18284166: D18817.diff
Aug 23 2025, 4:20 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/diffusion-observed-mercurial-repository-history-broken/825.

In D18769, I rewrote this from using the --branch flag (which is unsafe and does not function on branches named --config=x.y and such).

However, this rewrite accidentally changed the result order, which impacted Mercurial commit hisotry lists and graphs. Swap the order of the constraints so we get newest-to-oldest again, as expected.

Test Plan

Viewed a Mercurial repository's history graph, saw sensible chronology after the patch.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable