Use the correct "completed" time in Harbormaster display UI
ClosedPublic
Actions

Authored by epriestley on Jun 30 2017, 2:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 28, 10:01 AM

	Unknown Object (File)
	Thu, Apr 25, 12:03 AM

	Unknown Object (File)
	Fri, Apr 19, 6:38 PM

	Unknown Object (File)
	Thu, Apr 11, 8:20 AM

	Unknown Object (File)
	Apr 3 2024, 12:56 PM

	Unknown Object (File)
	Mar 30 2024, 4:48 AM

	Unknown Object (File)
	Mar 5 2024, 1:39 AM

	Unknown Object (File)
	Feb 19 2024, 12:50 PM

View All 85 Files

Subscribers

Restricted Owners Package

Tokens

"Like" token, awarded by yelirekim.

Details

Reviewers

chad
amckinley

Maniphest Tasks

T12883: Harbormaster build completion information displays build start time

Commits

rPeab8d8a22c4f: Use the correct "completed" time in Harbormaster display UI

Summary

Fixes T12883. The task seems correct to me and I think this is a copy/paste mistake that probably blames to me.

Test Plan

Fiddled these numbers, viewed a build in Harbormaster, saw the adjusted time.

Diff Detail

Repository

rP Phabricator

Branch

harbor1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17613
Build 23642: Run Core Tests
Build 23641: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 30 2017, 2:03 PM

Owners added a subscriber: Restricted Owners Package.Jun 30 2017, 2:03 PM

chad accepted this revision.Jun 30 2017, 2:04 PM

This revision is now accepted and ready to land.Jun 30 2017, 2:04 PM

Harbormaster completed remote builds in B17613: Diff 43725.Jun 30 2017, 2:04 PM

Closed by commit rPeab8d8a22c4f: Use the correct "completed" time in Harbormaster display UI (authored by epriestley, committed by epriestley). · Explain WhyJun 30 2017, 2:11 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12883: Harbormaster build completion information displays build start time.Jun 30 2017, 2:13 PM

yelirekim awarded a token.Jun 30 2017, 2:47 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterBuildViewController.php

2 lines

Diff 43725

View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Use the correct "completed" time in Harbormaster display UIClosedPublicActions