HomePhabricator

Move misplaced validation for ambiguous fields in "Test Plan" to the right place

Description

Move misplaced validation for ambiguous fields in "Test Plan" to the right place

Summary:
When users use the web UI to enter text like "Reviewers: x" into the "Summary" or "Test Plan", we can end up with an ambiguous commit message.

Some time ago we added a warning about this to the "Summary" field, and attempted to add it to the "Test Plan" field, but it actually gets called from the wrong place.

Remove the code from the wrong place (no callers, not reachable) and put it in the right place.

This fixes an issue where users could edit a test plan from the web UI to add the text "Tests: ..." and cause ambiguities on a later "arc diff --edit".

Test Plan:

Screen Shot 2017-06-30 at 6.24.30 AM.png (1×2 px, 330 KB)

Reviewers: chad, amckinley

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18175

Details

Provenance
epriestleyAuthored on Jun 30 2017, 1:24 PM
epriestleyPushed on Jun 30 2017, 1:36 PM
Reviewer
chad
Differential Revision
D18175: Move misplaced validation for ambiguous fields in "Test Plan" to the right place
Parents
rP83266e805c46: Update people image for projects
Branches
Unknown
Tags
Unknown
Build Status
Buildable 17611
Build 23638: Run Core Tests