Page MenuHomePhabricator

Correct file PHID extraction on image update in Pholio
ClosedPublic

Authored by epriestley on May 30 2017, 6:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 6:27 AM
Unknown Object (File)
Fri, Nov 15, 7:43 AM
Unknown Object (File)
Thu, Nov 14, 12:55 PM
Unknown Object (File)
Sat, Nov 9, 1:56 PM
Unknown Object (File)
Tue, Nov 5, 7:43 AM
Unknown Object (File)
Tue, Nov 5, 4:53 AM
Unknown Object (File)
Thu, Oct 31, 7:36 PM
Unknown Object (File)
Sun, Oct 27, 12:29 AM
Subscribers
None

Details

Summary

Ref T12776. This extraction of file PHIDs extracted "PholioImage" object PHIDs (PHID-PIMG-...), not "File" PHIDs (PHID-FILE-...). Instead, dig into the Pholio images and actually extract the file PHIDs. This method is now similar to the PholioImageFileTransaction method, which works already.

Test Plan
  • Create a mock.
  • Update one of the images.
  • In Files, view the "Attached" tab of the updated image.
  • Before patch: not attached to mock.
  • After patch: properly attached to mock.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable