Page MenuHomePhabricator

Correct file PHID extraction on image update in Pholio
ClosedPublic

Authored by epriestley on May 30 2017, 6:52 PM.
Tags
None
Referenced Files
F18836769: D18042.diff
Mon, Oct 27, 3:35 AM
F18797472: D18042.id43397.diff
Fri, Oct 17, 5:05 AM
F18743382: D18042.id43396.diff
Thu, Oct 2, 11:27 PM
F18728344: D18042.id.diff
Sep 30 2025, 9:22 AM
F18705637: D18042.id.diff
Sep 28 2025, 12:19 PM
F18702498: D18042.diff
Sep 28 2025, 12:21 AM
F18607738: D18042.id43396.diff
Sep 14 2025, 12:09 AM
F18606336: D18042.diff
Sep 13 2025, 10:08 PM
Subscribers
None

Details

Summary

Ref T12776. This extraction of file PHIDs extracted "PholioImage" object PHIDs (PHID-PIMG-...), not "File" PHIDs (PHID-FILE-...). Instead, dig into the Pholio images and actually extract the file PHIDs. This method is now similar to the PholioImageFileTransaction method, which works already.

Test Plan
  • Create a mock.
  • Update one of the images.
  • In Files, view the "Attached" tab of the updated image.
  • Before patch: not attached to mock.
  • After patch: properly attached to mock.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable