Page MenuHomePhabricator

Correct file PHID extraction on image update in Pholio
ClosedPublic

Authored by epriestley on May 30 2017, 6:52 PM.
Tags
None
Referenced Files
F19945221: D18042.id.diff
Thu, Apr 16, 4:01 PM
F19912288: D18042.id43396.diff
Thu, Apr 2, 6:20 PM
F19828943: D18042.diff
Mar 9 2026, 11:59 PM
F19828306: D18042.diff
Mar 9 2026, 5:42 PM
F19804342: D18042.id43396.diff
Mar 2 2026, 7:01 AM
F19802244: D18042.diff
Mar 1 2026, 2:59 PM
F19686155: D18042.id.diff
Feb 9 2026, 11:45 AM
F19532106: D18042.id43396.diff
Jan 20 2026, 8:58 AM
Subscribers
None

Details

Summary

Ref T12776. This extraction of file PHIDs extracted "PholioImage" object PHIDs (PHID-PIMG-...), not "File" PHIDs (PHID-FILE-...). Instead, dig into the Pholio images and actually extract the file PHIDs. This method is now similar to the PholioImageFileTransaction method, which works already.

Test Plan
  • Create a mock.
  • Update one of the images.
  • In Files, view the "Attached" tab of the updated image.
  • Before patch: not attached to mock.
  • After patch: properly attached to mock.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable