Redraw the Differential keyboard reticle after collapsing/un-collapsing an inline
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 2:05 PM.

Details

Reviewers

Maniphest Tasks

T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it
T12634: Keyboard focus reticle is generally oblivious to the world around it

Commits

rP665ff4fdf6e7: Redraw the Differential keyboard reticle after collapsing/un-collapsing an…

Summary

Ref T12634. Fixes T10049. Toggling an inline currently leaves the reticle oddly-positioned.

Test Plan

Selected a comment with the keyboard.
Collapsed it.
Saw reticle behave reasonably.

Diff Detail

Repository

rP Phabricator

Branch

focus5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16990
Build 22713: Run Core Tests
Build 22712: arc lint + arc unit

Event Timeline

epriestley created this revision.May 16 2017, 2:05 PM

Harbormaster completed remote builds in B16990: Diff 43062.May 16 2017, 2:06 PM

epriestley mentioned this in T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it.May 16 2017, 2:07 PM

chad accepted this revision.May 16 2017, 2:27 PM

This revision is now accepted and ready to land.May 16 2017, 2:27 PM

Closed by commit rP665ff4fdf6e7: Redraw the Differential keyboard reticle after collapsing/un-collapsing an… (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 3:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

2 lines

Diff 43062

View Options

resources/celerity/map.php