Page MenuHomePhabricator
Differential D17802

Add nullable type hint support to xhpast
Needs ReviewPublic
Actions

Authored by richardvanvelzen on Apr 28 2017, 8:43 AM.
Tags
None
Referenced Files
F13050042: D17802.id42806.diff
Fri, Apr 19, 2:35 AM
F13050041: D17802.id42805.diff
Fri, Apr 19, 2:35 AM
F13050040: D17802.id42804.diff
Fri, Apr 19, 2:35 AM
F13050039: D17802.id.diff
Fri, Apr 19, 2:35 AM
Unknown Object (File)
Thu, Apr 11, 9:37 AM
Unknown Object (File)
Thu, Apr 11, 3:55 AM
Unknown Object (File)
Thu, Apr 4, 1:45 AM
Unknown Object (File)
Mon, Apr 1, 9:10 PM
View All 95 Files
Subscribers
Firehed
joshuaspence
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4334: Support PHP5.4+ syntax in XHPAST
Summary

Ref T4334. This implements a new node type for type hints in general, and uses them to add nullability to a type hint.

Test Plan

Added test cases.

Diff Detail

Repository
rPHU libphutil
Branch
nullable-type-hints
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16732
Build 22321: arc lint + arc unit

Event Timeline

richardvanvelzen created this revision.Apr 28 2017, 8:43 AM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 28 2017, 8:43 AM
Herald added subscribers: Firehed, Korvin. · View Herald Transcript
richardvanvelzen added inline comments.Apr 28 2017, 8:44 AM
src/parser/xhpast/__tests__/data/nullable-type-hints.php.test
1

Darn

richardvanvelzen updated this revision to Diff 42805.Apr 28 2017, 8:46 AM

Remove copy-flag from new unit test (caused by copy-via-IDE)

richardvanvelzen updated this revision to Diff 42806.Apr 28 2017, 8:48 AM

For real now :(

richardvanvelzen added a comment.May 1 2017, 1:43 PM

This does not appear to have any impact on arc/lint.

richardvanvelzen edited the summary of this revision. (Show Details)May 1 2017, 1:43 PM
epriestley edited edge metadata.May 1 2017, 1:44 PM

(This and the other change look good to me, I just want to look at them in more detail and maybe take a stab at fixing the awful unreadable test cases while we're here.)

richardvanvelzen added a comment.May 1 2017, 5:14 PM

Sure, no problem. Let me know if there is something I can do to help

richardvanvelzen mentioned this in D17817: Add support for exponentiation.May 3 2017, 12:30 PM
joshuaspence added a subscriber: joshuaspence.May 3 2017, 12:34 PM
epriestley mentioned this in D17819: Make PHPAST parser tests stable and human-readable.May 3 2017, 5:07 PM
epriestley mentioned this in T4334: Support PHP5.4+ syntax in XHPAST.May 3 2017, 5:24 PM

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
__tests__/
data/
497 lines
14 lines
56 lines
168 lines
28 lines
bin/
2 lines
1 line
support/
xhpast/
1 line
17 lines
3968 lines
1 line
22 lines
194 lines
2 lines

Diff 42806

View Options

src/parser/xhpast/__tests__/data/nullable-type-hints.php.test

Loading...
View Options

src/parser/xhpast/__tests__/data/php-callable-typehint.php.test

Loading...
View Options

src/parser/xhpast/__tests__/data/php-syntax.php.test

Loading...
View Options

src/parser/xhpast/__tests__/data/return-type.php.test

Loading...
View Options

src/parser/xhpast/__tests__/data/variadic.php.test

Loading...
View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

src/parser/xhpast/parser_nodes.php

Loading...
View Options

support/xhpast/generate_nodes.php

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/parser_nodes.php

Loading...
View Options

support/xhpast/scanner.lex.hpp

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility