Page MenuHomePhabricator

Correct two parameter strictness issues with file uploads
ClosedPublic

Authored by epriestley on Apr 10 2017, 10:49 PM.
Tags
None
Referenced Files
F14172088: D17651.diff
Sun, Dec 8, 3:07 AM
Unknown Object (File)
Wed, Dec 4, 6:18 PM
Unknown Object (File)
Sat, Nov 30, 6:15 PM
Unknown Object (File)
Fri, Nov 29, 1:02 PM
Unknown Object (File)
Wed, Nov 27, 11:08 AM
Unknown Object (File)
Mon, Nov 25, 3:26 AM
Unknown Object (File)
Sat, Nov 23, 11:48 AM
Unknown Object (File)
Thu, Nov 21, 12:57 AM
Subscribers

Details

Summary

Fixes T12531. Strictness fallout from adding typechecking in D17616.

  • chunkedHash is not a real parameter, so the new typechecking was unhappy about it.
  • mime-type no longer allows null.
Test Plan
  • Ran arc upload --conduit-uri ... 12MB.zero on a 12MB file full of zeroes.
  • Before patch: badness, failure, fallback to one-shot uploads.
  • After patch: success and glory.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence added inline comments.
src/applications/files/conduit/FileUploadChunkConduitAPIMethod.php
70

Is this meant to be $params['mime-type']? Otherwise it looks like $mime_type is unused.

epriestley removed a reviewer: joshuaspence.
  • Actually set 'mime-type'.
This revision was automatically updated to reflect the committed changes.

I removed him accidentally by racing arc diff against his accept. T12109 is a rough description.

That is, he got removed here, when an arc diff with Reviewers: chad in the message took effect:

Screen Shot 2017-04-10 at 5.11.01 PM.png (80×450 px, 20 KB)